Opened 7 years ago

Closed 6 years ago

#38405 closed defect (fixed)

mochiweb fails to build for erlang upgraded to R16B

Reported by: su1shi4fu3@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.1.3
Keywords: haspatch Cc: ryandesign (Ryan Schmidt)
Port: mochiweb

Description (last modified by ryandesign (Ryan Schmidt))

After erlang got upgraded to R16B, mochiweb (v2.3.2) fails to build.
Proposed solution: upgrade mochiweb to current head from github.
(The latest tagged version of mochiweb, 2.4.2, also fails to build.)

Attachments (5)

mochiweb.patch (828 bytes) - added by su1shi4fu3@… 7 years ago.
Patch
mochiweb.2.patch (894 bytes) - added by su1shi4fu3@… 7 years ago.
patch for Portfile
mochiweb-edoc.patch (928 bytes) - added by su1shi4fu3@… 7 years ago.
mochiweb.3.patch (920 bytes) - added by su1shi4fu3@… 7 years ago.
patch (with epoch)
erlang-mochiweb-Portfile.patch (715 bytes) - added by su1shi4fu3@… 7 years ago.
Update mochiweb to 2.7.0

Download all attachments as: .zip

Change History (13)

Changed 7 years ago by su1shi4fu3@…

Attachment: mochiweb.patch added

Patch

comment:1 Changed 7 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added
Description: modified (diff)
Keywords: haspatch added
Port: mochiweb added

Using a git commitish as a user-facing version number is not optimal.

Could we update to 2.4.2 instead, then patch it with whatever upstream changes are needed to make it work with erlang R16B? Or would those patches be very large?

Changed 7 years ago by su1shi4fu3@…

Attachment: mochiweb.2.patch added

patch for Portfile

Changed 7 years ago by su1shi4fu3@…

Attachment: mochiweb-edoc.patch added

comment:2 Changed 7 years ago by su1shi4fu3@…

The patch would be very small. (Actually, the code itself builds with mochiweb v2.4.2, but "make edoc" fails. I attached a new patch for the Portfile and a patch make makes "make edoc" work.)

comment:3 Changed 7 years ago by su1shi4fu3@…

One more remark: in the new patch, I removed the 'epoch' field. I don't know why the original port creator put it there. Maybe I overlooked something?

comment:4 Changed 7 years ago by ryandesign (Ryan Schmidt)

Once it's in a port, the epoch line can never be removed or decreased.

Changed 7 years ago by su1shi4fu3@…

Attachment: mochiweb.3.patch added

patch (with epoch)

comment:5 Changed 7 years ago by su1shi4fu3@…

Ooops, I overlooked this. Thanks! Since the original port author used a date-like thing in the epoch, I guess I will stick with this. (New patch including an incremented epoch attached).

Changed 7 years ago by su1shi4fu3@…

Update mochiweb to 2.7.0

comment:6 Changed 7 years ago by su1shi4fu3@…

Mochiweb has been updated to 2.7.0, which builds now cleanly with macports. No additional patchfile needed. Patch to upgrade mochiweb is attached.

comment:7 Changed 6 years ago by jocelyn.fournier@…

Any plan to integrate this fix into macport ? (I need mochiweb for RabbitMQ server)

comment:8 Changed 6 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.