xconsole @1.0.5 build fails due to -Werror

[cooljeanius (Eric Gallager)]

While trying to install xorg-apps, MacPorts hit an error with xconsole:

make[2]: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_x11_xconsole/xconsole/work/xconsole-1.0.5'
  CC     xconsole.o
xconsole.c:816:35: warning: declaration shadows a variable in the global scope [-Wshadow]
get_pty(int *pty, int *tty, char *ttydev, char *ptydev)
                                  ^
xconsole.c:188:13: note: previous declaration is here
static char ttydev[64], ptydev[64];
            ^
xconsole.c:816:49: warning: declaration shadows a variable in the global scope [-Wshadow]
get_pty(int *pty, int *tty, char *ttydev, char *ptydev)
                                                ^
xconsole.c:188:25: note: previous declaration is here
static char ttydev[64], ptydev[64];
                        ^
xconsole.c:819:6: error: implicit declaration of function 'openpty' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        if (openpty(pty, tty, NULL, NULL, NULL) == -1) {
            ^
2 warnings and 1 error generated.
make[2]: *** [xconsole.o] Error 1
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_x11_xconsole/xconsole/work/xconsole-1.0.5'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_x11_xconsole/xconsole/work/xconsole-1.0.5'
make: *** [all] Error 2
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_x11_xconsole/xconsole/work/xconsole-1.0.5'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_x11_xconsole/xconsole/work/xconsole-1.0.5" && /usr/bin/make -j4 -w all 
Exit code: 2
Error: org.macports.build for port xconsole returned: command execution failed

Full log is attached.

[cooljeanius (Eric Gallager)]

main.log for xconsole

[cooljeanius (Eric Gallager)]

Actually never mind, I can't reproduce this myself any more. Our school computers recently upgraded to Mountain Lion and xconsole now builds properly for me. Feel free to close as invalid.