Opened 6 years ago

Closed 6 years ago

#38616 closed update (fixed)

yara: update to 1.7

Reported by: a.schuster@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.1.3
Keywords: haspatch maintainer Cc: ryandesign (Ryan Schmidt)
Port: yara

Description

Updated YARA to version 1.7. Added variants to build either with re2 or pcre support.

Attachments (2)

Portfile (1.4 KB) - added by a.schuster@… 6 years ago.
Portfile.diff (1.2 KB) - added by a.schuster@… 6 years ago.

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by a.schuster@…

Attachment: Portfile added

comment:1 Changed 6 years ago by cooljeanius (Eric Gallager)

Diff between this and the current Portfile?

comment:2 in reply to:  1 Changed 6 years ago by a.schuster@…

Replying to egall@…:

Diff between this and the current Portfile?

.. is now attached to the ticket.

comment:3 Changed 6 years ago by ryandesign (Ryan Schmidt)

Keywords: haspatch maintainer added
Summary: Update: yara to 1.7yara: update to 1.7

Thanks. Some observations:

  • The $Id$ line should not be removed.
  • When updating to a new version, the revision line should be removed or set to 0.
  • "universal_variant yes" is the default and does not need to be mentioned explicitly.
  • The pcre variant just adds a dependency; that's usually not sufficient. The port needs to ensure that the pcre library will not be used if the pcre variant is not selected.

comment:4 in reply to:  3 ; Changed 6 years ago by a.schuster@…

Replying to ryandesign@…:

Thanks. Some observations:

Thanks for your helpful comments! I've attached a revised Portfile.

  • The $Id$ line should not be removed.
  • When updating to a new version, the revision line should be removed or set to 0.
  • "universal_variant yes" is the default and does not need to be mentioned explicitly.

done.

  • The pcre variant just adds a dependency; that's usually not sufficient. The port needs to ensure that the pcre library will not be used if the pcre variant is not selected.

Now there's only one variant that enables re2, and at the same time disables pcre.

Changed 6 years ago by a.schuster@…

Attachment: Portfile.diff added

comment:5 in reply to:  4 Changed 6 years ago by ryandesign (Ryan Schmidt)

Replying to a.schuster@…:

Now there's only one variant that enables re2, and at the same time disables pcre.

Ok, that works.

I didn't mind the two conflicting variants, in fact I usually prefer that when there is a choice of two different libraries for a feature (vs. when it's just a choice of whether to enable or disable a feature, in which case a single variant should be used). What I minded was that you left open the possibility that the user could deselect both of the variants, which would then still use pcre if it was installed but not declare a dependency on it.

comment:6 in reply to:  4 Changed 6 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added
Resolution: fixed
Status: newclosed

Replying to a.schuster@…:

Thanks for your helpful comments! I've attached a revised Portfile.

r105138

Note: See TracTickets for help on using tickets.