Opened 8 years ago
Closed 8 years ago
#38616 closed update (fixed)
yara: update to 1.7
Reported by: | a.schuster@… | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.1.3 |
Keywords: | haspatch maintainer | Cc: | ryandesign (Ryan Schmidt) |
Port: | yara |
Description
Updated YARA to version 1.7. Added variants to build either with re2 or pcre support.
Attachments (2)
Change History (8)
Changed 8 years ago by a.schuster@…
comment:1 follow-up: 2 Changed 8 years ago by cooljeanius (Eric Gallager)
comment:2 Changed 8 years ago by a.schuster@…
comment:3 follow-up: 4 Changed 8 years ago by ryandesign (Ryan Schmidt)
Keywords: | haspatch maintainer added |
---|---|
Summary: | Update: yara to 1.7 → yara: update to 1.7 |
Thanks. Some observations:
- The
$Id$
line should not be removed. - When updating to a new version, the
revision
line should be removed or set to 0. - "universal_variant yes" is the default and does not need to be mentioned explicitly.
- The pcre variant just adds a dependency; that's usually not sufficient. The port needs to ensure that the pcre library will not be used if the pcre variant is not selected.
comment:4 follow-ups: 5 6 Changed 8 years ago by a.schuster@…
Replying to ryandesign@…:
Thanks. Some observations:
Thanks for your helpful comments! I've attached a revised Portfile.
- The
$Id$
line should not be removed.- When updating to a new version, the
revision
line should be removed or set to 0.- "universal_variant yes" is the default and does not need to be mentioned explicitly.
done.
- The pcre variant just adds a dependency; that's usually not sufficient. The port needs to ensure that the pcre library will not be used if the pcre variant is not selected.
Now there's only one variant that enables re2, and at the same time disables pcre.
Changed 8 years ago by a.schuster@…
Attachment: | Portfile.diff added |
---|
comment:5 Changed 8 years ago by ryandesign (Ryan Schmidt)
Replying to a.schuster@…:
Now there's only one variant that enables re2, and at the same time disables pcre.
Ok, that works.
I didn't mind the two conflicting variants, in fact I usually prefer that when there is a choice of two different libraries for a feature (vs. when it's just a choice of whether to enable or disable a feature, in which case a single variant should be used). What I minded was that you left open the possibility that the user could deselect both of the variants, which would then still use pcre if it was installed but not declare a dependency on it.
comment:6 Changed 8 years ago by ryandesign (Ryan Schmidt)
Cc: | ryandesign@… added |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Replying to a.schuster@…:
Thanks for your helpful comments! I've attached a revised Portfile.
Diff between this and the current Portfile?