Opened 11 years ago
Last modified 11 years ago
#38757 assigned submission
New pianod, wsgw ports
| Reported by: | perette (Perette Barella) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.3 |
| Keywords: | Cc: | ||
| Port: | pianod wsgw |
Description
Pianod (Pandora music daemon) & wsgw (websocket gateway required for web client).
Attachments (2)
Change History (8)
Changed 11 years ago by perette (Perette Barella)
Changed 11 years ago by perette (Perette Barella)
| Attachment: | Portfile.2 added |
|---|
comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
| Owner: | changed from macports-tickets@… to ryandesign@… |
|---|---|
| Port: | pianod wsgw added |
| Status: | new → assigned |
Thanks. I committed pianod in r105222 with these changes:
- tabs to spaces, some reformatting and rearranging of lines
- removed "configure.args --mandir=${prefix}/share/man" because that is the default for pianod's configure script
comment:2 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
The buildbots failed to build the port due to lack of pkgconfig. Fixed in r105224.
comment:3 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
For the wsgw port, I don't think it should install a startup item or have a pianod variant. It's a generic websocket proxy; it could forward any number of services, and I don't think we want to be in the business of providing a variant for each such service. And, if I try to load the launchd plist without having selected the pianod variant, it doesn't start, because no services have been defined.
A better strategy would be to either do nothing, or to use the notes command to print some helpful messages for the user telling them how to use it.
comment:4 Changed 11 years ago by perette (Perette Barella)
Okay, so would a better strategy be for wsgw to install itself and pianod with a +wsgw option to depend on wsgw, and install/configure an instance of wsgw for it to use? That could be problematic if multiple services want to configure their own instances (not that anything other than pianod is using wsgw at the moment.)
comment:5 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
I'm not sure that the ports should be tied together in any way. Is it too much to ask the user to set up their own launchd plist that matches their needs? The manpage for wsgw shows an example of using pop3 for example.
comment:6 Changed 11 years ago by perette (Perette Barella)
I defer to you on that question, as it goes to how MacPorts identifies their role. If MacPorts is just a package installer, then I agree the two would be independent and the end user can glue them together. But if the role is to simplify things for the end user, then (like the GNU Autotools philosophy) a bit more burden on the developer end is favorable if it eases things for users.
wsgw portfile