Gnuplot demo folder and documentation missing

[pwolter@…]

The gnuplot package is not complete. The demo files are completely missing. Moreover, if you "manually" download them and try them out as outlined in ​http://www.gnuplot.info/screenshots/index.html#demos you get just errors. Even if you install/copy the 4.6 examples from sourceforge.

[larryv (Lawrence Velázquez)]

Thanks for the ticket. In the future, please Cc relevant port maintainers and do not set the Priority field.

[mojca (Mojca Miklavec)]

I can difinitely add demo files when I upload version 4.6.3. The only question is where.

However, if you want to get the errors fixed, you need to point out what errors you get exactly.

If these are font-related, you might have to install some font to run the demos.

It might be a version-mismatch: some feature that has only been introduced in 4.7 and doesn't work in 4.6 yet for example.

It might be a broken terminal (non-working library or some mac-specific problem).

If it's a different problem, I suggest to report the problem upstream. Broken demo is not something that a packager can solve. (Broken terminal might be.)

[mojca (Mojca Miklavec)]

I figured out that demos contain a bunch of files that shouldn't be installed/copied, like "Makefile", "Makefile.in" etc. If someone suggests a nice patch to copy the files, I'll add it, else I'll try to get it fixed upstream first. The problem is that I'm neither sure where the demo files should go nor am I aware of which files should not be installed. I opened a bug report:

• ​https://sourceforge.net/p/gnuplot/bugs/1234/

and let's see what comes out of it.

[mojca (Mojca Miklavec)]

The upstream replied with won't-fix. MacPorts can fix this, but I need some concrete suggestions.

[mojca (Mojca Miklavec)]

Here's the proposed patch:

--- Portfile
+++ Portfile
@@ -179,9 +179,15 @@
         xinstall -m 0644 ${luadir}/gnuplot-lua-tikz.tex        ${texmf}/tex/plain/gnuplot-lua-tikz
     }
 
-    xinstall -d -m 0755 ${destroot}${prefix}/share/doc/${name}
-    xinstall -m 0644 ${distpath}/${name}.pdf \
-        ${destroot}${prefix}/share/doc/${name}
+    set destdocdir ${destroot}${prefix}/share/doc/${name}
+    xinstall -d -m 0755 ${destdocdir}
+    xinstall -m 0644 ${distpath}/${name}.pdf ${destdocdir}
+
+    # copy demo files
+    file copy ${workpath}/${distname}/demo ${destdocdir}
+    foreach {makefile} {Makefile Makefile.in Makefile.am Makefile.am.in} {
+        delete ${destdocdir}/demo/${makefile}
+    }
 }
 
 # this temporary workaround removes files that accidentally circumvented destroot

I would be grateful for feedback, but as it requires a revision bump and is not urgent, I suggest to wait for the next opportunity when either version or revision will change.

[mf2k (Frank Schima)]

@mojca: Please always attach patches to a ticket instead of pasting inline.

[mojca (Mojca Miklavec)]

a patch to install demo files for gnuplot

[mojca (Mojca Miklavec)]

Here it is. (I'm thinking of waiting for gd2 patch which will need a revbump anyway, this could be patched just before/after that.)

[cooljeanius (Eric Gallager)]

Cc Me!

[mojca (Mojca Miklavec)]

Fixed in r108795.