#38799 closed enhancement (fixed)
Add bash_completion variant to mosh (patch included)
| Reported by: | macports@… | Owned by: | quentinmit (Quentin Smith) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | neverpanic (Clemens Lang) |
| Port: | mosh |
Description
The attached patch adds a bash_completion variant to mosh. This allows mosh to auto-complete known host names just like ssh does.
Attachments (1)
Change History (9)
Changed 11 years ago by macports@…
| Attachment: | mosh-bash-completion.patch added |
|---|
comment:1 follow-up: 2 Changed 11 years ago by neverpanic (Clemens Lang)
| Cc: | cal@… added; quentin@… removed |
|---|---|
| Owner: | changed from macports-tickets@… to quentin@… |
comment:2 follow-up: 3 Changed 11 years ago by cooljeanius (Eric Gallager)
Replying to cal@…:
Looks good to me. I'd probably even install it without a variant, i.e. always and by default. Let me know what you think.
How about somewhere halfway between the two: making the variant a default variant?
comment:3 Changed 11 years ago by larryv (Lawrence Velázquez)
Replying to egall@…:
How about somewhere halfway between the two: making the variant a default variant?
I don’t see the point of this. It’s one file. Just install it all the time, sans the dependency on bash-completion.
comment:4 follow-up: 5 Changed 11 years ago by quentinmit (Quentin Smith)
LGTM. I don't care if it's protected by a variant or not, but it does seem like the standard is to offer it as a variant?
comment:5 Changed 11 years ago by macports@…
Replying to quentin@…:
LGTM. I don't care if it's protected by a variant or not, but it does seem like the standard is to offer it as a variant?
I guess so - see https://trac.macports.org/wiki/howto/bash-completion.
comment:6 Changed 11 years ago by jmroot (Joshua Root)
| Port: | mosh added |
|---|
comment:7 Changed 11 years ago by neverpanic (Clemens Lang)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
port echo variant:bash_completion | wc -l shows only 12 ports that actually have a +bash_completion variant. It seems uncommon and I'll post to the -dev list suggesting to remove the remaining variants.
Meanwhile, I have commited this patch in r105276.
Looks good to me. I'd probably even install it without a variant, i.e. always and by default. Let me know what you think.