Opened 11 years ago
Closed 11 years ago
#38901 closed enhancement (fixed)
libxc @2.0.1 license info not listed
| Reported by: | dstrubbe (David Strubbe) | Owned by: | fabian.renn@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | larryv (Lawrence Velázquez) | |
| Port: | libxc |
Description
'port info libxc' says 'License: unknown'. This should be filled in: the COPYING file in libxc 2.0.1 states that the license is Lesser GPL v3.
+license LGPL-3
Attachments (1)
Change History (8)
comment:1 Changed 11 years ago by mf2k (Frank Schima)
| Cc: | fabian.renn@… removed |
|---|---|
| Owner: | changed from macports-tickets@… to fabian.renn@… |
| Port: | libxc added |
| Type: | update → enhancement |
| Version: | 2.1.3 |
comment:2 Changed 11 years ago by dstrubbe (David Strubbe)
I am attaching a patch that
- adds the license, as above;
- removes "-C -ansi" from the FCCPP line, which is not necessary (as I mentioned in #38915); and
- adds livecheck.
comment:3 follow-up: 4 Changed 11 years ago by jmroot (Joshua Root)
| Cc: | larryv@… added |
|---|
Nitpick: license should be LGPL-3+ since the notices in the source files allow any later version.
Larry, you added the FCCPP. Any insight into why you used -C -ansi?
comment:4 Changed 11 years ago by larryv (Lawrence Velázquez)
I think it was just to parallel the configure script’s default value for FCCPP, which is /lib/cpp -C -ansi.
comment:5 Changed 11 years ago by dstrubbe (David Strubbe)
Ok. Well, I found where that default originally traces back to (http://www.tddft.org/trac/octopus/changeset/1352/trunk/build/acx.m4) in the Octopus project from which libxc was spun out. The specific concern was C++ style comments in preprocessed Fortran files. There are no such comments in F90 files in libxc, so we do not need -ansi.
Changed 11 years ago by dstrubbe (David Strubbe)
| Attachment: | Portfile-libxc.diff added |
|---|
comment:7 Changed 11 years ago by mf2k (Frank Schima)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
r106288. Maintainer timeout.
In the future, please fill in the Port field.