Opened 6 years ago

Closed 6 years ago

#39273 closed defect (fixed)

libsodium 0.4.1: bogus curvecp variant

Reported by: jpo@… Owned by: brian.andrew@…
Priority: Normal Milestone:
Component: ports Version: 2.1.3
Keywords: haspatch maintainer Cc: ryandesign (Ryan Schmidt)
Port: libsodium

Description

The libsodium 0.41 curvecp variant is bogus: the configure doesn't support the --enable-curvecp option

  • port variants libsodium
    libsodium has the variants:
       curvecp: include support for curvecp
       universal: Build for multiple architectures
    
  • Portfile: superfluous lines
    ...
    variant curvecp description {include support for curvecp } {
        configure.args-append  --enable-curvecp
    }
    

Attachments (1)

libsodium.diff (366 bytes) - added by brian.andrew@… 6 years ago.
Removing variant

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by jpo@…

There is a section about CurveCP at the end of the README.markdown file (https://github.com/jedisct1/libsodium) where it is mentioned that CurveCP support is provided by projects libchloride and libcurvecpr.

comment:2 Changed 6 years ago by mf2k (Frank Schima)

Cc: brian.andrew@… removed
Owner: changed from macports-tickets@… to brian.andrew@…

Changed 6 years ago by brian.andrew@…

Attachment: libsodium.diff added

Removing variant

comment:3 Changed 6 years ago by brian.andrew@…

My fault, wasn't paying close enough attention. --enable-curvecp was superseded by the libchloride library (Portfile submission right after this.) In talking with Frank Denis (developer of libsodium/libchloride) it sounds like libchloride may end up being merged into libcurvecpr. Tried to make a Portfile for libcurvecp, but it wasn't clean. Will see what I can do.

Can someone +haspatch +maintainer this?

comment:4 Changed 6 years ago by brian.andrew@…

Opened #39275 for libchloride Port.

comment:5 Changed 6 years ago by larryv (Lawrence Velázquez)

Keywords: haspatch maintainer added

comment:6 Changed 6 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added
Resolution: fixed
Status: newclosed

Thanks: r106603

Note: See TracTickets for help on using tickets.