webkit-gtk +quartz incorrectly pulls in X11 functionality

[pokui@…]

Hi all,

If xorg-libXcomposite one gets build errors thusly:

--->  Configuring webkit-gtk
...
checking for XCOMPOSITE... no
configure: error: Package requirements (xcomposite) were not met:

No package 'xcomposite' found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Also if xorg-libXdamage isn't installed you also get something similar:

checking for XCOMPOSITE... yes
checking for XDAMAGE... no
configure: error: Package requirements (xdamage) were not met:

No package 'xdamage' found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

[pokui@…]

add missing ports to depends_lib

[dbevans (David B. Evans)]

Thanks for your report. However, the approach you propose is not the direction we want to go. The point of +quartz here is to remove any X11 dependencies not add more.

You didn't attach a detailed build log but I just tried a clean build of the current version (2.0.3) as follows:

sudo port selfupdate
sudo port deactivate active  \\ you might want to save a list of your current active ports before you do this
sudo port install webkit-gtk +quartz +video -x11 +no_x11 -universal

Configure completed successfully but build failed.

In file included from Source/WebCore/bridge/NP_jsobject.cpp:30:
In file included from ./Source/WebCore/bridge/NP_jsobject.h:31:
./Source/WebCore/bridge/npruntime_internal.h:33:14: fatal error: 'X11/Xresource.h' file not found
    #include <X11/Xresource.h>
             ^
In file included from Source/WebCore/bridge/npruntime.cpp:31:
./Source/WebCore/bridge/npruntime_internal.h:33:14: fatal error: 'X11/Xresource.h' file not found
    #include <X11/Xresource.h>

Obviously some X11 stuff remains. See attached build.log for more details.

I'm going to refer this to jeremyhu as he understands this port better than I do.

[dbevans (David B. Evans)]

Recent version 2.0.3 build log

[cooljeanius (Eric Gallager)]

Cc Me!

[c.herbig@…]

Cc Me!

[c.herbig@…]

Replying to devans@…:

Obviously some X11 stuff remains. See attached build.log for more details.

This latter part is the subject of ticket #39898, I'm cross-referencing it here in case anybody else runs into the same issue. Unfortunately, the only solution I could find was to just add port:xorg-libX11 as a dependency. Unlike #39756, the offending X11 code cannot simply be commented out/deleted, so a real solution will have to be negotiated upstream at some point...

[jeremyhu (Jeremy Huddleston Sequoia)]

#40622

[jeremyhu (Jeremy Huddleston Sequoia)]

Reopening, let's use this as the original...

[jeremyhu (Jeremy Huddleston Sequoia)]

This looks fixed by quartz-webcore.patch and is upstream: ​https://bugs.webkit.org/show_bug.cgi?id=126326