Opened 11 years ago

Last modified 10 years ago

#39355 new submission

xyzsh @1.4.3

Reported by: noreply@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.1.3
Keywords: Cc: kurthindenburg (Kurt Hindenburg)
Port: xyzsh

Description


Attachments (2)

Portfile (1.1 KB) - added by noreply@… 11 years ago.
Portfile.2 (1.4 KB) - added by rino@… 11 years ago.
Revised version of Portfile on Jun 9.

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by noreply@…

Attachment: Portfile added

comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Thanks. Some observations:

  • The standard modeline should be added, and the stray tab character should be converted to spaces.
  • Listing just an md5 checksum is deprecated. Please list at least two checksums per file, preferably rmd160 and sha256.
  • The port built just fine for me without libc-headers and libm-headers, and listing them as dependencies is problematic because libc-headers doesn't have a universal variant, which prevents xyzsh's universal variant from working. What's the reason for these dependencies?
  • --prefix=/opt/local should be removed from configure.args. MacPorts might be installed in a different prefix. MacPorts already adds the correct prefix in configure.pre_args for you.
  • If possible, the port should always build a static library and dynamic library; there should be no +static variant. However, trying to build the port with the +static variant results in the error "make: *** No rule to make target 'all'. Stop."
  • Instead of using install_name_tool to fix the library reference in the program after the fact, the install_name of the library itself needs to be set correctly at build time.
  • The livecheck doesn't work.

comment:2 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Also, the files installed by xyzsh link with the ncurses and oniguruma5 libraries, so they're need to be in depends_lib not depends_build.

Changed 11 years ago by rino@…

Attachment: Portfile.2 added

Revised version of Portfile on Jun 9.

comment:3 Changed 11 years ago by rino@…

Thank you very much for your kindly suggestion. I hope everything is fine with this Portfile.

  • The standard modeline is added.
  • List rmd160 and sha256 for checksum.
  • Adding libc- and libm-headers as dependencies was my mistake. They are removed.
  • --prefix and +static variant are removed.
  • Changed to specify install_name at build time...however, I'm not sure this is the right way.
  • The livecheck is added.
  • Changed from depends_build to depends_lib.
Last edited 11 years ago by rino@… (previous) (diff)

comment:4 Changed 10 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:5 Changed 10 years ago by kurthindenburg (Kurt Hindenburg)

I wasn't aware +static could be used - it doesn't error out but doesn't appear to do anything here.

Rino, if you want to update this to 1.5.8, I'll commit it for you.

Note: See TracTickets for help on using tickets.