Opened 7 years ago

Last modified 6 weeks ago

#39424 new enhancement

Ports that use qmake: consider using the new qmake portgroup

Reported by: cooljeanius (Eric Gallager) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: blair (Blair Zajac), neverpanic (Clemens Lang), cssdev, ctreleaven (Craig Treleaven), drkp (Dan Ports), easye, ecronin (Eric Cronin), macports@…, MarcusCalhoun-Lopez (Marcus Calhoun-Lopez), michaelld (Michael Dickens), mkae (Marko Käning), mnick@…, NicosPavlov, ocroquette (Olivier Croquette), phw@…, pixilla (Bradley Giesbrecht), rowue@…, rudloff@…, ryandesign (Ryan Schmidt), sami.laine@…, nerdling (Jeremy L), kurthindenburg (Kurt Hindenburg)
Port: arora clustalx GLC_lib goldendict k3dsurf kdiff3 OpenCSG openscad psi-otr qgit QMK-Groundstation qt-assistant qt4-creator-mac qtc-qtsharp qtpfsgui qtscriptgenerator qtsharp QupZilla qwt qxmpp sqlitedbrowser tea tiled

Description (last modified by kencu (Ken))

(Made as a separate ticket per comment:ticket:38280:22) There is now a qmake portgroup as of r106912. Here is a list of ports that use qmake somewhere in their respective portfiles:

[moved to attachment:qmake_search.txt because it’s pointless and makes ticket modification emails enormous. —larryv]

List of ports that still need to be fixed:

  • k3dsurf (nomaintainer) - purely based on qt3. upstream inactive since 2005.
  • psi-otr (rowue)
  • qgit (nomaintainer)
  • qt-assistant (michaelld, openmaintainer)
  • qtc-qtsharp (nomaintainer) - Upstream homepage dead
  • qtscriptgenerator (michaelld, openmaintainer)
  • qtsharp (nomaintainer) - Upstream homepage dead
  • qwt (michaelld, openmaintainer)
  • qxmpp (nomaintainer)
  • sqlitedbrowser (nomaintainer)

List of completed/irrelevant ports:

Maintainers of these ports, consider whether you could use the qmake portgroup for your respective ports.

Attachments (1)

qmake_search.txt (26.0 KB) - added by larryv (Lawrence Velázquez) 7 years ago.
original search output, removed from ticket description

Download all attachments as: .zip

Change History (53)

comment:1 Changed 7 years ago by ctreleaven (Craig Treleaven)

I've browsed the linked tickets, but I didn't notice a reason that this is a separate port group. Why not just add these bits to the qt4 port group (maybe version 2.0)?

Also, I noticed the line:

    configure.pre_args-delete       --prefix=${prefix}

I'm pretty sure mythtv-core.25 needs that argument. Is it harmful to other ports?

comment:2 in reply to:  1 Changed 7 years ago by cooljeanius (Eric Gallager)

Replying to ctreleaven@…:

I've browsed the linked tickets, but I didn't notice a reason that this is a separate port group. Why not just add these bits to the qt4 port group (maybe version 2.0)?

I wanted to just include this in the qt4 portgroup, too, but apparently not all ports that use the qt4 portgroup use qmake, so that's why there's now a separate qmake portgroup. See comment:ticket:38272:1 for reference.

Last edited 7 years ago by cooljeanius (Eric Gallager) (previous) (diff)

comment:3 Changed 7 years ago by NicosPavlov

The portgroup is not meant for all ports using qmake. For example, several ports use qmake within standard autotools, thus compiling by

configure
make

These ports are not concerned by this portgroup, as they define variables during the configuration phase. However, several other ports must be compiled through

qmake
make

The portgroup aims at setting variables for these ports.

Typically, in case the configuration phase is made with qmake, the --prefix argument is not used, and PREFIX is, hence the changes of variables in the portgroup. Due to these differences, it did not appear suitable to include these in the qt4 portgroup which is more general for ports depending on qt4.

comment:4 Changed 7 years ago by mkae (Marko Käning)

Done for abtransfers in r106975

comment:5 Changed 7 years ago by mkae (Marko Käning)

I think gwenhywfar4 should be taken out of the above list, since it uses configure!

comment:6 in reply to:  5 Changed 7 years ago by cooljeanius (Eric Gallager)

Replying to mk@…:

I think gwenhywfar4 should be taken out of the above list, since it uses configure!

I'd edit it to do so, except people without commit access can't edit the OP's of tickets (even if they're their own tickets), so I can't (yet)...

comment:7 Changed 7 years ago by ctreleaven (Craig Treleaven)

mythtv-core.25 also uses ./configure and would not benefit from this portgroup.

(And yes, tickets can be assigned to us...but we can't close them or do anything more than comment on them!)

comment:8 Changed 7 years ago by larryv (Lawrence Velázquez)

Description: modified (diff)
Port: gwenhywfar4 mythtv-core.25 removed

Removed gwenhywfar4 and mythtv-core.25.

comment:9 in reply to:  description Changed 7 years ago by larryv (Lawrence Velázquez)

Replying to egall@…:

Here is a list of ports that use qmake somewhere in their respective portfiles:

By the way, please use better judgment in the future when pasting a ton of output from logs or stdout into ticket descriptions or comments. Where by “use better judgment” I mean “don’t do it”.

comment:10 Changed 7 years ago by NicosPavlov

Description: modified (diff)

qtiplot done in r106995.
Suppressing djview as it uses configure.

comment:11 Changed 7 years ago by raphael-st (Raphael Straub)

Cc: raphael@… removed
Description: modified (diff)

libQGLViewer done in r107011.

comment:12 Changed 7 years ago by mkae (Marko Käning)

Description: modified (diff)

modified abtransfers' Portfile in r107026

Changed 7 years ago by larryv (Lawrence Velázquez)

Attachment: qmake_search.txt added

original search output, removed from ticket description

comment:13 Changed 7 years ago by larryv (Lawrence Velázquez)

Description: modified (diff)

comment:14 Changed 7 years ago by NicosPavlov

Description: modified (diff)

I passed through the listed ports, and tried to clean up the irrelevant ones, i.e. the ones for which the quake portgroup would be of no use.

  • Ports using standard autotools (eg ./configure): bitdht, cmake, doxygen, qca, qfsm, Vidalia
  • Ports using cmake: gnuradio
  • Ports using python: py-pyqt4, py26-pyqt3
  • Ports without configure phase: xxdiff

Additionally, I noted that some ports employ some conditional code to take into account the case of qt3, which is not considered in the portgroup for now.

I also made a note beside ports which have no maintainer.

comment:15 Changed 7 years ago by neverpanic (Clemens Lang)

What's the rationale behind setting configure.* in a pre-configure block in the PortGroup? This makes it difficult to change the defaults given in the PortGroup.

comment:16 in reply to:  15 Changed 7 years ago by cooljeanius (Eric Gallager)

Replying to cal@…:

What's the rationale behind setting configure.* in a pre-configure block in the PortGroup? This makes it difficult to change the defaults given in the PortGroup.

I think nicos did that in comment:ticket:38280:20...

comment:17 Changed 7 years ago by NicosPavlov

Sorry I did not answer right away.

If I did put those in a pre-configure block, it is because otherwise, the flags were not set right if the portfile was for example setting configure.blacklist, as flags such as QMAKE_CC must be set accordingly, and after having blacklisted compilers. This is also why all flags are with -delete or -append. However, I fully get the point, and if there is another more convenient way of ensuring that some commands are followed that I am not aware of, it surely could improve the portgroup.

comment:18 Changed 7 years ago by easye

Description: modified (diff)

Addressed for finance/bitcoin in r108515.

comment:19 Changed 7 years ago by macports@…

Fixed for qt4-creator-mac in r107796.

comment:20 Changed 7 years ago by sharky@…

Cc: sharky@… removed

Cc Me!

comment:21 Changed 7 years ago by mojca (Mojca Miklavec)

Port: abtransfers bitcoin bitdht cmake djview doxygen gnuradio libQGLViewer py-pyqt4 py26-pyqt3 qca qfsm qtiplot Vidalia xxdiff removed

Removed abtransfers bitcoin bitdht cmake djview doxygen gnuradio libQGLViewer py-pyqt4 py26-pyqt3 qca qfsm qtiplot Vidalia xxdiff.

comment:22 Changed 6 years ago by mf2k (Frank Schima)

Cc: mf2k@… added; macsforever2000@… removed

comment:23 Changed 6 years ago by mf2k (Frank Schima)

Description: modified (diff)
Version: 2.1.3

comment:24 Changed 6 years ago by mf2k (Frank Schima)

Description: modified (diff)

comment:25 Changed 6 years ago by mf2k (Frank Schima)

OpenCSG switched in r120659.

comment:26 Changed 6 years ago by mf2k (Frank Schima)

Description: modified (diff)

openscad r125699

comment:27 Changed 6 years ago by mf2k (Frank Schima)

Description: modified (diff)

comment:28 Changed 6 years ago by ryandesign (Ryan Schmidt)

QupZilla done in r125940

comment:29 Changed 6 years ago by ryandesign (Ryan Schmidt)

tiled done in r125941

comment:30 Changed 6 years ago by ryandesign (Ryan Schmidt)

Description: modified (diff)

tea done in r125942

comment:31 Changed 6 years ago by ryandesign (Ryan Schmidt)

Description: modified (diff)

goldendict done in r125945

comment:32 Changed 6 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:33 Changed 6 years ago by kurthindenburg (Kurt Hindenburg)

Description: modified (diff)

kdiff3 done in r127115

comment:34 Changed 6 years ago by mf2k (Frank Schima)

Cc: mf2k@… removed

comment:35 Changed 5 years ago by michaelld (Michael Dickens)

Description: modified (diff)
Port: qwtplot3d removed

qwtplot3d done in r138217.

comment:36 Changed 5 years ago by michaelld (Michael Dickens)

QMK-Groundstation has a patch for this in #48226.

comment:37 Changed 5 years ago by michaelld (Michael Dickens)

Description: modified (diff)
Port: qt3 qt3-mac qt4-mac qt4-mac-mysql55-plugin qt4-mac-postgresql91-plugin qt4-mac-sqlite2-plugin qt4-x11 removed

qt4-mac-sqlite2-plugin done in r138220. qt4-mac-mysql55-plugin done in r138224. qt4-mac-postgresql91-plugin done in r138227. qt3, qt3-mac, qt4-x11, and qt4-mac cannot use this PortGroup.

comment:38 Changed 5 years ago by michaelld (Michael Dickens)

Description: modified (diff)

QMK-Groundstation done in r140991.

comment:39 Changed 4 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

qtpfsgui fixed in r149176.

comment:40 Changed 3 years ago by mojca (Mojca Miklavec)

Description: modified (diff)
Port: qscintilla removed

qscintilla fixed in b9de20c6

comment:41 Changed 21 months ago by ryandesign (Ryan Schmidt)

In 346a60ff1acc996b7830b877763a114bf09ef934/macports-ports (master):

clustalx: Fix build failures

Fix build failures due to lack of <string> include and lack of path to
Qt frameworks.

Closes: #43306

Include qmake portgroup to simplify the portfile and to use the right
-arch flags, which also enables the universal variant. This also fixes
qt4-mac to be a library dependency, which requires increasing the
revision.

See: #39424

comment:42 Changed 19 months ago by yan12125 (Chih-Hsuan Yen)

Cc: yan12125 added

comment:43 Changed 19 months ago by yan12125 (Chih-Hsuan Yen)

In 48565da617e90ab46887be37c9b8b551284c9c05/macports-ports (master):

texstudio: use qmake5 PortGroup

configure and build arguments are already configured in this port group

Ref: #39424

comment:44 Changed 19 months ago by yan12125 (Chih-Hsuan Yen)

Description: modified (diff)
Port: texstudio removed

comment:45 Changed 17 months ago by mf2k (Frank Schima)

Description: modified (diff)

comment:46 Changed 17 months ago by mf2k (Frank Schima)

Description: modified (diff)

comment:47 Changed 15 months ago by mf2k (Frank Schima)

Description: modified (diff)

comment:48 Changed 15 months ago by Mihai Moldovan <ionic@…>

In 2b292f41894577ca90da9fa6d8dc0c5989977933/macports-ports (master):

aqua/x2goclient: use qmake-1.0 PG, fix +debug variant.

Revbump, since the debug variant was horribly broken before.

See: #39424

comment:49 in reply to:  48 Changed 15 months ago by Ionic (Mihai Moldovan)

Description: modified (diff)
Port: x2goclient removed

comment:50 Changed 8 months ago by yan12125 (Chih-Hsuan Yen)

Cc: yan12125 removed

comment:51 Changed 6 weeks ago by kencu (Ken)

In 06d3394794e9367e19f0f5b1cbd739fc08b11eee/macports-ports (master):

GLC_lib: update to 2.2.0

closes: #55854
closes: #47418
see: #39424

Examples work.
There is a newer version 3.0.1
see: #55854

that uses qt5 but didn't build for Ryan two years ago
and didn't build for me either after some trying

This gets the port into a working state while it is
decided how best to handle 3.0.1 and whether to keep
both a qt4 and qt5 version of this in MacPorts

comment:52 Changed 6 weeks ago by kencu (Ken)

Description: modified (diff)
Note: See TracTickets for help on using tickets.