Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#39477 closed update (fixed)

varnish @3.0.3: upgrade to 3.0.4

Reported by: robsonpeixoto@… Owned by: Gminfly
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: robert@…, cooljeanius (Eric Gallager), nerdling (Jeremy Lavergne)
Port: varnish

Description

  • Upgrade to 3.0.4
  • Add vim modeline
  • Fix style
  • Add reload vlc script from archlinux
  • Add varnish.conf file (make config easer)
  • Add init script (need to varnish.conf work)

Attachments (5)

varnish-3.0.4.patch (5.6 KB) - added by robsonpeixoto@… 7 years ago.
0001-Upgrade-to-3.0.4.patch (1.2 KB) - added by robsonpeixoto@… 7 years ago.
0002-Fix-style-and-add-vim-modeline.patch (2.1 KB) - added by robsonpeixoto@… 7 years ago.
0003-Add-scripts-to-make-the-administration-more-easer.patch (6.4 KB) - added by robsonpeixoto@… 7 years ago.
varnish-without-whitespace.diff (3.1 KB) - added by nerdling (Jeremy Lavergne) 6 years ago.
patch ignoring whitespace

Download all attachments as: .zip

Change History (18)

Changed 7 years ago by robsonpeixoto@…

Attachment: varnish-3.0.4.patch added

comment:1 Changed 7 years ago by larryv (Lawrence Velázquez)

Cc: pmq@… removed
Owner: changed from macports-tickets@… to pmq@…
Summary: varnish: upgrade to 3.0.4varnish @3.0.3: upgrade to 3.0.4

There are too many things going on in this patch.

  • Please submit separate patches for functional changes and whitespace/formatting changes.
  • You cannot remove the epoch field; this resets it to 0 and ensures that the new version will always be seen as older than the previous one.
  • Is there seriously no easier way to have Varnish start up than by running our own custom script?

Changed 7 years ago by robsonpeixoto@…

Attachment: 0001-Upgrade-to-3.0.4.patch added

Changed 7 years ago by robsonpeixoto@…

Changed 7 years ago by robsonpeixoto@…

comment:2 Changed 7 years ago by robsonpeixoto@…

IMHO, this config file is better than edit /Library/LaunchDaemons/org.macports.varnish.plist or create a script.

Using my approach, is possible to use the 'port load varnish' and 'port unload varnish', and keep the config save on upgrade.

If I edit the org.macports.varnish.plist, on a upgrade of the package, I'll lost all my config.

comment:3 Changed 7 years ago by robsonpeixoto@…

Thanks about the epoch =D

comment:4 Changed 6 years ago by mf2k (Frank Schima)

The patches do not seem to apply for me.

comment:5 Changed 6 years ago by robert@…

With exception to the 0001 patch, the other patch files (0002,0003 & varnish-3.0.4.patch) fail at one or another hunk. There also seems to be a little inconsistency with the patch options to get them to apply (i.e., 0003 requires the patch "-p1" option, otherwise the "files" folder gets put in a "b" folder).

I'm all for this patch so hopefully we can get it updated or have these changes moved into the Varnish port.

comment:6 Changed 6 years ago by robert@…

Cc: robert@… added

Cc Me!

comment:7 Changed 6 years ago by robsonpeixoto@…

Thanks for the review, but I'm not using MacPorts anymore. So, I can't fix theses patches.

comment:8 in reply to:  7 Changed 6 years ago by mf2k (Frank Schima)

Replying to robsonpeixoto@…:

Thanks for the review, but I'm not using MacPorts anymore. So, I can't fix theses patches.

OK. I have also removed you as maintainer from php-Twig in r120821.

comment:9 Changed 6 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:10 Changed 6 years ago by mf2k (Frank Schima)

Owner: changed from pmq@… to normen@…

Assigning to new maintainer.

Changed 6 years ago by nerdling (Jeremy Lavergne)

patch ignoring whitespace

comment:11 Changed 6 years ago by nerdling (Jeremy Lavergne)

Cc: snc@… added
Resolution: fixed
Status: newclosed

Updated in r121138.

comment:12 Changed 6 years ago by robert@…

The epoch field is missing. Is it necessary as mentioned above? I'm not seeing my varnish 3.0.3 install showing up as outdated and didn't know if this was why.

comment:13 Changed 6 years ago by nerdling (Jeremy Lavergne)

Yes, absolutely. Thanks for catching it. Updated in r121139

Note: See TracTickets for help on using tickets.