#39477 closed update (fixed)
varnish @3.0.3: upgrade to 3.0.4
| Reported by: | robsonpeixoto@… | Owned by: | Gminfly |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | robert@…, cooljeanius (Eric Gallager), nerdling (Jeremy Lavergne) |
| Port: | varnish |
Description
- Upgrade to 3.0.4
- Add vim modeline
- Fix style
- Add reload vlc script from archlinux
- Add varnish.conf file (make config easer)
- Add init script (need to varnish.conf work)
Attachments (5)
Change History (18)
Changed 11 years ago by robsonpeixoto@…
| Attachment: | varnish-3.0.4.patch added |
|---|
comment:1 Changed 11 years ago by larryv (Lawrence Velázquez)
| Cc: | pmq@… removed |
|---|---|
| Owner: | changed from macports-tickets@… to pmq@… |
| Summary: | varnish: upgrade to 3.0.4 → varnish @3.0.3: upgrade to 3.0.4 |
Changed 11 years ago by robsonpeixoto@…
| Attachment: | 0001-Upgrade-to-3.0.4.patch added |
|---|
Changed 11 years ago by robsonpeixoto@…
| Attachment: | 0002-Fix-style-and-add-vim-modeline.patch added |
|---|
Changed 11 years ago by robsonpeixoto@…
| Attachment: | 0003-Add-scripts-to-make-the-administration-more-easer.patch added |
|---|
comment:2 Changed 11 years ago by robsonpeixoto@…
IMHO, this config file is better than edit /Library/LaunchDaemons/org.macports.varnish.plist or create a script.
Using my approach, is possible to use the 'port load varnish' and 'port unload varnish', and keep the config save on upgrade.
If I edit the org.macports.varnish.plist, on a upgrade of the package, I'll lost all my config.
comment:5 Changed 10 years ago by robert@…
With exception to the 0001 patch, the other patch files (0002,0003 & varnish-3.0.4.patch) fail at one or another hunk. There also seems to be a little inconsistency with the patch options to get them to apply (i.e., 0003 requires the patch "-p1" option, otherwise the "files" folder gets put in a "b" folder).
I'm all for this patch so hopefully we can get it updated or have these changes moved into the Varnish port.
comment:7 follow-up: 8 Changed 10 years ago by robsonpeixoto@…
Thanks for the review, but I'm not using MacPorts anymore. So, I can't fix theses patches.
comment:8 Changed 10 years ago by mf2k (Frank Schima)
Replying to robsonpeixoto@…:
Thanks for the review, but I'm not using MacPorts anymore. So, I can't fix theses patches.
OK. I have also removed you as maintainer from php-Twig in r120821.
comment:10 Changed 10 years ago by mf2k (Frank Schima)
| Owner: | changed from pmq@… to normen@… |
|---|
Assigning to new maintainer.
Changed 10 years ago by nerdling (Jeremy Lavergne)
| Attachment: | varnish-without-whitespace.diff added |
|---|
patch ignoring whitespace
comment:11 Changed 10 years ago by nerdling (Jeremy Lavergne)
| Cc: | snc@… added |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Updated in r121138.
comment:12 Changed 10 years ago by robert@…
The epoch field is missing. Is it necessary as mentioned above? I'm not seeing my varnish 3.0.3 install showing up as outdated and didn't know if this was why.
comment:13 Changed 10 years ago by nerdling (Jeremy Lavergne)
Yes, absolutely. Thanks for catching it. Updated in r121139
There are too many things going on in this patch.
epochfield; this resets it to 0 and ensures that the new version will always be seen as older than the previous one.