Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#39532 closed update (fixed)

pianobar: update to 2013.09.15

Reported by: ryandesign (Ryan Schmidt) Owned by: aguynamedryan+pianobar@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: brian.andrew@…, lpsinger (Leo Singer)
Port: pianobar

Description

$ port livecheck pianobar
pianobar seems to have been updated (port version: 2012.12.01, new version: 2013.05.19)

Attachments (1)

pianobar_20130915-1.diff (1.8 KB) - added by brian.andrew@… 6 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by ryandesign (Ryan Schmidt)

Summary: pianobar: update to 2013.05.19pianobar: update to 2013.09.15
$ port livecheck pianobar
pianobar seems to have been updated (port version: 2012.12.01, new version: 2013.09.15)

comment:2 Changed 6 years ago by ryandesign (Ryan Schmidt)

Cc: brian.andrew@… added
Keywords: haspatch added

Duplicate #40921 has a patch, but I'm worried about all the things it removes. I have a feeling some of it (like UsingTheRightCompiler and -arch flags and adding a universal variant and preventing upgrade errors) is still needed.

comment:3 Changed 6 years ago by brian.andrew@…

You were right to be cautious. After some more testing it does turn out that my changes completely removed the ability to generate a universal port. I'm not sure why to be honest, I thought that was available by default. Anyway, here's a much milder patch that doesn't make as many sweeping changes, but still works.

I guess I should just trust that if something is in a Portfile, it's probably there for a reason ;-)

Changed 6 years ago by brian.andrew@…

Attachment: pianobar_20130915-1.diff added

comment:4 in reply to:  3 Changed 6 years ago by ryandesign (Ryan Schmidt)

Replying to brian.andrew@…:

After some more testing it does turn out that my changes completely removed the ability to generate a universal port. I'm not sure why to be honest, I thought that was available by default.

It is—assuming the port uses an autoconf-compatible configure script. pianobar doesn't (c.f. use_configure no).

I guess I should just trust that if something is in a Portfile, it's probably there for a reason ;-)

Or use svn blame and svn log to determine why something is in a Portfile.

comment:5 Changed 6 years ago by lpsinger (Leo Singer)

Cc: aronnax@… added

Cc Me!

comment:6 Changed 6 years ago by lpsinger (Leo Singer)

The patch worked for me.

comment:7 Changed 6 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: newclosed

Committed in r112643, though I see now that the source code is still available on the web site like it was before, and it's bz2 compressed, so I'm not sure why we switched to downloading from github which is gz compressed and thus larger.

comment:8 Changed 6 years ago by brian.andrew@…

I thought it made the port cleaner and given that even the website indicates that github is the place for up-to-date source/info it made sense to me to switch.

Note: See TracTickets for help on using tickets.