Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#39546 closed submission (fixed)

New port: Patoline

Reported by: pierreetienne.meunier@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.1.3
Keywords: Cc: cooljeanius (Eric Gallager)
Port: patoline

Description

This is a new typesetting system, written in OCaml.

Attachments (5)

Portfile (824 bytes) - added by pierreetienne.meunier@… 7 years ago.
Portfile.2 (1.1 KB) - added by cooljeanius (Eric Gallager) 7 years ago.
Revised portfile for Patoline
main.log (96.0 KB) - added by cooljeanius (Eric Gallager) 7 years ago.
build failure log for patoline
Portfile.3 (1.1 KB) - added by pierreetienne.meunier@… 7 years ago.
Portfile.4 (1.1 KB) - added by pierreetienne.meunier@… 7 years ago.

Download all attachments as: .zip

Change History (11)

Changed 7 years ago by pierreetienne.meunier@…

Attachment: Portfile added

comment:1 Changed 7 years ago by cooljeanius (Eric Gallager)

port -v lint --nitpick reports the following warning:

Warning: Maintainer email address should be obfuscated as gmail.com:pierreetienne.meunier

Also some other things to consider:

  • Most ports have modelines for their first line nowadays, like this:
    # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
    
  • The "GPL" license requires a version number. In this case, it looks like it's version 2 (or later? If it is "or later", use a "+" with the version of the GPL, so it would be "GPL-2+".)
  • If you're going to just keep the description and long_description the same, you can just replace the text for your long_description with the variable ${description}
  • Since this is an ocaml port, consider using the ocaml portgroup: browser:trunk/dports/_resources/port1.0/group/ocaml-1.0.tcl This removes the need to manually specify a dependency on ocaml, among other things.
  • Ports should generally have at least two checksums; since you're already using sha256, the next-strongest one after that (that MacPorts uses, at least) is rmd160.

Anyway, I re-did the portfile with those changes, which I'll attach next. Unfortunately, building it fails for me, with the error:

make[2]: Entering directory `/opt/local/var/macports/build.build/_opt_local_var_macports_sources_LocalPorts_ocaml_patoline/patoline/work/patoline-0.1/src/Format'
ocamlfind ocamlopt -pp "cpp -w" -I ../Typography/_build -I ../Rbuffer -package camomile,camlzip,camlimages.all_formats -a -o FormatSlides.cmxa FormatSlides.ml
File "FormatSlides.ml", line 970, characters 32-33:
Error: This expression has type Typography.Document.node
       but an expression was expected of type
         Typography.OutputCommon.structure
make[2]: *** [FormatSlides.cmxa] Error 2
make[2]: Leaving directory `/opt/local/var/macports/build.build/_opt_local_var_macports_sources_LocalPorts_ocaml_patoline/patoline/work/patoline-0.1/src/Format'
make[1]: *** [Format/FormatSlides.cmxa] Error 2
make[1]: Leaving directory `/opt/local/var/macports/build.build/_opt_local_var_macports_sources_LocalPorts_ocaml_patoline/patoline/work/patoline-0.1/src'
make: *** [all] Error 2
make: Leaving directory `/opt/local/var/macports/build.build/_opt_local_var_macports_sources_LocalPorts_ocaml_patoline/patoline/work/patoline-0.1'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_LocalPorts_ocaml_patoline/patoline/work/patoline-0.1" && /usr/bin/make -w all 
Exit code: 2

I'll attach my main.log, too.

Changed 7 years ago by cooljeanius (Eric Gallager)

Attachment: Portfile.2 added

Revised portfile for Patoline

Changed 7 years ago by cooljeanius (Eric Gallager)

Attachment: main.log added

build failure log for patoline

comment:2 Changed 7 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:3 in reply to:  description Changed 7 years ago by pierreetienne.meunier@…

Thanks for your comments! I do not get this error. However, I have attempted to correct it. Here is a new portfile.

Changed 7 years ago by pierreetienne.meunier@…

Attachment: Portfile.3 added

Changed 7 years ago by pierreetienne.meunier@…

Attachment: Portfile.4 added

comment:4 Changed 7 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Port: patoline added
Status: newassigned

comment:5 Changed 7 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed

Thanks for the port! I committed it with a few minor changes in r107724.

comment:6 Changed 7 years ago by ryandesign (Ryan Schmidt)

This ticket supersedes #34432.

Note: See TracTickets for help on using tickets.