Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#40419 closed update (fixed)

Gnumeric @1.12.7_0: add quartz variant and OS X menu bar integration

Reported by: c.herbig@… Owned by: larryv (Lawrence Velázquez)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc:
Port: gnumeric

Description

Adds +quartz with OS X menu bar integration via gtk-osx-application.

Attachments (6)

Portfile-gnumeric.diff (1.1 KB) - added by c.herbig@… 8 years ago.
patch_quartz-src-GNOME_Gnumeric-gtk.xml.in.diff (582 bytes) - added by c.herbig@… 8 years ago.
patch_quartz-src-wbc-gtk.c.diff (2.0 KB) - added by c.herbig@… 8 years ago.
patch_quartz-src-GNOME_Gnumeric-gtk.xml.in.2.diff (828 bytes) - added by c.herbig@… 8 years ago.
patch_quartz-src-wbc-gtk.c.2.diff (2.1 KB) - added by c.herbig@… 8 years ago.
Portfile-gnumeric.2.diff (958 bytes) - added by c.herbig@… 8 years ago.
removes revision 1

Download all attachments as: .zip

Change History (17)

Changed 8 years ago by c.herbig@…

Attachment: Portfile-gnumeric.diff added

Changed 8 years ago by c.herbig@…

Changed 8 years ago by c.herbig@…

comment:1 Changed 8 years ago by c.herbig@…

Hold up, I noticed that this removes View > Toolbars > *, I figured out the problem, I'll get a new patch up soon...

comment:2 Changed 8 years ago by c.herbig@…

Comment 1 fixed and tidied up a bit more.

Changed 8 years ago by c.herbig@…

Changed 8 years ago by c.herbig@…

comment:3 Changed 8 years ago by c.herbig@…

This ticket also closes #15560.

comment:4 Changed 8 years ago by cooljeanius (Eric Gallager)

While you're at it, could you also add libgnomedb as a dependency for the +database variant?

comment:5 Changed 8 years ago by mf2k (Frank Schima)

The revision should not be increased just because you are adding a new variant.

comment:6 Changed 8 years ago by c.herbig@…

Fixed

Changed 8 years ago by c.herbig@…

Attachment: Portfile-gnumeric.2.diff added

removes revision 1

comment:7 in reply to:  4 Changed 8 years ago by larryv (Lawrence Velázquez)

Owner: changed from macports-tickets@… to larryv@…
Status: newassigned
Summary: Gnumeric @1.12.7 to 1.12.7.1Gnumeric @1.12.7_0: add quartz variant and OS X menu bar integration
Version: 2.2.0

Replying to egall@…:

While you're at it, could you also add libgnomedb as a dependency for the +database variant?

Open a separate ticket for this.

comment:8 Changed 8 years ago by larryv (Lawrence Velázquez)

Resolution: fixed
Status: assignedclosed

Committed in r110903. Thanks.

comment:9 in reply to:  4 ; Changed 8 years ago by c.herbig@…

Replying to egall@…:

While you're at it, could you also add libgnomedb as a dependency for the +database variant?

I can't get libgnomedb to compile, either the current version or the latest shipping version from ftp.gnome. I asked the Gnumeric developers if libgnomedb was relevant if libgda5 was provided, and they said not really. From what I can tell from the libgda project, libgnomedb has been superseded by libgda.

However, if you are able to get a working libgnomedb, it should be most trivial to add it.

comment:10 in reply to:  9 ; Changed 8 years ago by larryv (Lawrence Velázquez)

If libgda5 obsoletes libgnomedb, I don’t see any reason to add support for the latter.

comment:11 in reply to:  10 Changed 8 years ago by c.herbig@…

Replying to larryv@…:

If libgda5 obsoletes libgnomedb, I don’t see any reason to add support for the latter.

That is my interpretation of the situation based on the libgda site, if I am wrong, feel free to provide evidence to the contrary. Alternatively, if there is a pressing need to support such legacy software, I would consider that sufficient reason to provide support for libgnomedb, even if it means adding a +legacy variant or such. However, as mentioned, I cannot even get libgnomedb to compile, and don't have any more time to put into investigating it. Meanwhile, there is an immediate need to fix the libgda5 port so that it will actually be detected by the Gnumeric configure phase: #40314; it currently does not. I don't know enough about the port or other ports depending on it to feel comfortable applying those changes to the port file myself.

Note: See TracTickets for help on using tickets.