New port: ape

[fnog@…]

Submission of new port: Atomic Pseudopotentials Engine. Port is named "ape".

[ryandesign (Ryan Carsten Schmidt)]

Thanks. Some observations:

• The "# $Id$" line is missing. It should be the second line of the portfile, right after the modeline.
• The port provides gcc variants which set configure.compiler, but the port also includes the line "configure.args --with-libxc-prefix=${prefix} FCCPP="${configure.cc} -E -ansi"". This line will be executed before the variants are evaluated, which means ${configure.cc} will from that moment on be set to its default value (e.g. /usr/bin/clang on modern Xcode versions). To allow configure.compiler to affect configure.cc, ensure that you do not access the configure.cc variable until after the variants are evaluated. That means enclosing this line inside a pre-configure block.
• The port provides gcc46, gcc47 and gcc48 variants, but the pre-fetch section checks for not only those but also gcc42, gcc43, gcc44, gcc45 and g95. The port should only check for variants that are defined, or unexpected problems can arise (e.g. if the user requests one of those non-defined variants).
• The pre-fetch phase's ui_msg line should be removed; it seems like debugging information that users don't need to see.
• The pre-fetch block errors out if dependency libxc is not installed with the required variant. Couldn't this be done more simply using the require_active_variants procedure?

[fnog@…]

Modified portfile for APE

[davidfavor (David Favor)]

Just checking to see when this will be include in the mainline ports.

[dstrubbe (David Strubbe)]

Fixed in r131693.