Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#40617 closed update (fixed)

Update gobject-introspection @1.38.0

Reported by: juanrgar (Juan R. García Blanco) Owned by: neverpanic (Clemens Lang)
Priority: Normal Milestone:
Component: ports Version: 2.2.0
Keywords: Cc:
Port: gobject-introspection

Description

GNOME 3.10 was released just a few days ago, and obviously not all packages in macports have been updated to match the new release. I submit this update since gobject-introspection's maintainer is nomaintainer. If any gnome guy wants to take care of this, it'll be fine too.

Attachments (1)

Portfile-gobject-introspection.diff (2.2 KB) - added by juanrgar (Juan R. García Blanco) 11 years ago.
gobject-introspection @1.38.0 update

Download all attachments as: .zip

Change History (10)

comment:1 Changed 11 years ago by juanrgar (Juan R. García Blanco)

Cc: juanrgar@… added

Cc Me!

comment:2 Changed 11 years ago by neverpanic (Clemens Lang)

Keywords: gnome gobject removed
Owner: changed from macports-tickets@… to cal@…
Status: newassigned

I have some comments on this one:

  • The glibtool_path.patch is still needed, because libtool is a completely different program on OS X.
  • The patch-giscanner-dumper.py-clang-is-not-msvc.patch seems to be no longer required (but this should be tested; if any build using gobject-introspection fails because --msvc-syntax shows up in the compiler arguments, it's still needed).
  • The patch-giscanner-shlib.py-use-absolute-linkage-paths.patch patch is still needed.
  • The patch-giscanner-utils.py-use-absolute-linkage-paths.patch patch is still needed. These two patches allow using gobject-introspection-generated .typelibs without setting DYLD_LIBRARY_PATH or DYLD_FALLBACK_LIBRARY_PATH.
  • Removing the reinplaces will break dependent ports and should probably be avoided.

Thanks for stepping up as maintainer, though; you're very welcome.

comment:3 Changed 11 years ago by neverpanic (Clemens Lang)

Cc: juanrgar@… removed

You don't need to Cc yourself if you're the reporter.

comment:4 Changed 11 years ago by juanrgar (Juan R. García Blanco)

Thank you very much! I see I did quite a great job :( It compiled fine on my system and I took that as a license to remove the patches. Asap (I'm not home) I will attach a clean patch including the needed patches. Thank you ;)

comment:5 in reply to:  4 Changed 11 years ago by neverpanic (Clemens Lang)

Replying to juanrgar@…:

Thank you very much! I see I did quite a great job :( It compiled fine on my system and I took that as a license to remove the patches.

While that usually works fine, gobject-introspection is a special case, because you usually don't notice any problems until you try building other ports that use it or try to load the generated bindings in a target language.

Asap (I'm not home) I will attach a clean patch including the needed patches.

Don't worry, we're not in a particular hurry.

comment:6 Changed 11 years ago by juanrgar (Juan R. García Blanco)

I've checked that the contents of patch-giscanner-dumper.py-clang-is-not-msvc.patch are already merged in gobject-introspection source code. Here's what I've done to check this works:

Then I've run a basic gjs example and I've seen it working. I know this is not definitive though. I just uploaded this new version of the Portfile.

Changed 11 years ago by juanrgar (Juan R. García Blanco)

gobject-introspection @1.38.0 update

comment:7 Changed 11 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: assignedclosed

Looks good to me, committed in r111971.

I'll try to bring those patches into a form where they can be merged upstream and open a bug there.

comment:8 Changed 11 years ago by neverpanic (Clemens Lang)

comment:9 Changed 11 years ago by juanrgar (Juan R. García Blanco)

Thank you very much! I hope I will not disappoint the macports project ;)

Note: See TracTickets for help on using tickets.