Opened 11 years ago

Closed 11 years ago

#40635 closed update (fixed)

auto-multiple-choice @1.1.1: update to 1.2.1

Reported by: nortcele Owned by: dbevans (David B. Evans)
Priority: Normal Milestone:
Component: ports Version: 2.2.0
Keywords: Cc: clot@…
Port: auto-multiple-choice

Description

The patch change all lines for alignment. The author of AMC has contacted the maintainer and the maintainer tell him that he no longer has enough time to maintain the port. I could replace him and I put my address as a maintainer in the portfile.

Attachments (3)

auto-multiple-choice.diff (6.7 KB) - added by nortcele 11 years ago.
patch-changes-only.diff (4.1 KB) - added by dbevans (David B. Evans) 11 years ago.
Revised patch ignoring white space changes for clarity.
auto-multiple-choice.2.diff (3.7 KB) - added by nortcele 11 years ago.
New cleaner version of the patch

Download all attachments as: .zip

Change History (9)

Changed 11 years ago by nortcele

Attachment: auto-multiple-choice.diff added

comment:1 Changed 11 years ago by nortcele

Cc: Joel.Brogniart@… added

Cc Me!

comment:2 Changed 11 years ago by dbevans (David B. Evans)

Cc: Joel.Brogniart@… removed
Owner: changed from macports-tickets@… to devans@…
Status: newassigned

The ticket reporter is automatically CC'ed it's not necessary to CC yourself in addition.

comment:3 Changed 11 years ago by dbevans (David B. Evans)

Joel --

Thanks for your submission. A couple of comments:

1) It's very difficult so see what has actually been changed in your proposed patch because of the reformatting. Recommended procedure is to submit actual changes in one patch and reformatting in another to help with this problem. Have attached a revised patch that removes that white space only changes to make it more readable for now. Can add the reformatting in a subsequent patch.

2) You've declared a conflict with port auto-multiple-choice-devel but no such port currently exists. Do you plan to submit one?

3) The post-activate phase using gdk-pixbuf-query-loaders shouldn't be necessary unless this port installs a new gdk-pixbuf loader. I don't see one.

4) I would suggest that, in addition to your own name as maintainer, you add openmaintainer so that other committers can help make updates to the port when you are not available. Is that OK with you?

Having said that I have tested the port and it seems to install with no problems other than what I have mentioned above.

Changed 11 years ago by dbevans (David B. Evans)

Attachment: patch-changes-only.diff added

Revised patch ignoring white space changes for clarity.

comment:4 Changed 11 years ago by nortcele

1) Sorry for the extra work I gave you. I didn't know what was the best way to keep patch and portfile simple to read. I should have asked to the list.

2) Yes, I plan to submit a developer version later.

3) The post-activate phase solve a launching failure of the application for some users. I had this problem once and haven't been able to trace the source. This command prevents the problem from recurring. I'll remove this phase so If the problem occurs again, I'll try to see with the developer to solve it in the application.

4) It is OK to add openmaintainer.

Changed 11 years ago by nortcele

Attachment: auto-multiple-choice.2.diff added

New cleaner version of the patch

comment:5 Changed 11 years ago by dbevans (David B. Evans)

Committed changes only in r111771. I removed the conflicts statement for now. You can add it back when you submit the -devel version of the port.

White space changes committed in r111773.

Thanks for taking maintainership of this port that has been broken for some time.

Last edited 11 years ago by dbevans (David B. Evans) (previous) (diff)

comment:6 Changed 11 years ago by dbevans (David B. Evans)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.