Opened 7 years ago

Closed 7 years ago

#40658 closed update (fixed)

flac @1.2.1 upgrade to 1.3.0

Reported by: james.george@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.2.0
Keywords: haspatch Cc:
Port: flac

Description

I have created a patch to the flac @1.2.1 port to retrieve and install flac 1.3.0 from its new home at xiph.org.

One of the patches from the old 1.2.1 port no longer applies and didn't seem relevant so I've removed it from the patchfiles list, though it still exists, commented out in the diff.

Built and tested locally and it worked for me - 10.8.5 XCode5 MBP. Also built the xmms_plugin variant, though didn't test it.

FLAC 1.3.0 doesn't bring much new other than a few bug fixes and improved handling of high bit rate files. Replay gain processing for 24bit files being what I was after. :-)

Attachments (1)

Portfile-flac130.diff (1.6 KB) - added by james.george@… 7 years ago.
Patch to update to FLAC 1.3.0

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by james.george@…

Attachment: Portfile-flac130.diff added

Patch to update to FLAC 1.3.0

comment:1 Changed 7 years ago by ryandesign (Ryan Schmidt)

Cc: nomaintainer@… removed
Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

Thanks.

comment:2 in reply to:  description ; Changed 7 years ago by ryandesign (Ryan Schmidt)

Replying to james.george@…:

One of the patches from the old 1.2.1 port no longer applies and didn't seem relevant so I've removed it from the patchfiles list, though it still exists, commented out in the diff.

In Tcl, a backslash at the end of a line extends a comment to the next line. So you've in fact commented out all the patches, not just the one. I'll go through and check what all the patches were doing and see if they're still useful.

Also note that you can more simply use an xz distfile with the statement "use_xz yes".

Last edited 7 years ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:3 in reply to:  2 ; Changed 7 years ago by james.george@…

Replying to ryandesign@…:

In Tcl, a backslash at the end of a line extends a comment to the next line. So you've in fact commented out all the patches, not just the one. I'll go through and check what all the patches were doing and see if they're still useful.

Also note that you can more simply use an xz distfile with the statement "use_xz yes".

Really? Even in a comment line? That would explain the really odd error that I saw when I commented it out in-place. I shall have to keep that in mind. I missed use_xz when I read the Guide. Do you want me to rework the patch?

Cheers!

comment:4 in reply to:  3 Changed 7 years ago by ryandesign (Ryan Schmidt)

Replying to james.george@…:

Replying to ryandesign@…:

In Tcl, a backslash at the end of a line extends a comment to the next line. So you've in fact commented out all the patches, not just the one. I'll go through and check what all the patches were doing and see if they're still useful.

Really? Even in a comment line?

Really! Removing that line shows that at least one of the other patches doesn't even apply.

Do you want me to rework the patch?

That's ok, I'll work on it. I just also want to check all the other things the portfile already does because I'm not sure if they're still useful or correct.

comment:5 Changed 7 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed

Committed with changes in r111885.

Note: See TracTickets for help on using tickets.