Opened 7 years ago

Closed 7 years ago

#40691 closed update (fixed)

qgis @2.0.1: possible version issue with +grass variant

Reported by: petrrr Owned by: Veence (Vincent)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: cooljeanius (Eric Gallager)
Port: qgis

Description

This port hard-codes to grass version 6.4.2.

variant grass               description "Build Grass (6.42) plugin" {

    depends_lib-append      port:grass
    configure.args-append   \
                "-DGRASS_PREFIX=${prefix}/share/grass-6.4.2"
}

Now, grass is grass @6.4.3 (gis) and the respective path does not exist any more. Does this plugin work with 6.4.3 as well or does it really require version 6.4.2.

The build itself would not fail, however I wonder I this might cause problems during runtime?

Change History (6)

comment:1 Changed 7 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:2 Changed 7 years ago by ryandesign (Ryan Schmidt)

Cc: vince@… removed
Owner: changed from macports-tickets@… to vince@…

6.4.2 was presumably the current version of grass at the time this line was last changed in the Portfile. Now that grass is at 6.4.3 this line should presumably be changed.

Does qgis install files into this numbered directory? If so the port's revision should be increased when this is changed; if not, it should not.

Perhaps grass's version can be interrogated via pkg-config script or similar mechanism such that the qgis portfile doesn't need to be manually updated every time grass's version increases.

comment:3 Changed 7 years ago by Veence (Vincent)

I’m going to fix that tonight. Thanks for reporting.

comment:4 Changed 7 years ago by Veence (Vincent)

I have upgraded to 6.4.3 in r111992. I know it’s a kludge, but I can do no better tonight. I will figure out tomorrow if there is a more clever way (like, as suggested by Ryan, using a pkg-config API) to keep qgis automatically up to date as grass evolves.

comment:5 in reply to:  2 Changed 7 years ago by petrrr

Replying to ryandesign@…:

6.4.2 was presumably the current version of grass at the time this line was last changed in the Portfile. Now that grass is at 6.4.3 this line should presumably be changed.

Sure, I have assumed the same ...

Does qgis install files into this numbered directory? If so the port's revision should be increased when this is changed; if not, it should not.

Well even if it does not install into this directory, the path is probably used in some way (maybe a reference to it), otherwise it would not even make to pass it at all, right? Actually it's this line "-DGRASS_PREFIX=${prefix}/share/grass-6.4.3", which makes me think it might be save to bump revision in any case. At least as long the exact purpose is unclear. Some reference may remain invalid.

comment:6 Changed 7 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.