Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#40742 closed submission (fixed)

py-PyQGLViewer @0.11 submission

Reported by: christophe.pradal@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.2.0
Keywords: Cc:
Port: py-PyQGLViewer

Description

Tested on Mac 10.7.3.

This port has a dependency on libPyQGLViewer.

Attachments (2)

Portfile (2.2 KB) - added by christophe.pradal@… 6 years ago.
pythonpy-PyQGLViewer
Portfile.2 (2.2 KB) - added by christophe.pradal@… 6 years ago.
New Portfile replacing the old one

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by christophe.pradal@…

Attachment: Portfile added

pythonpy-PyQGLViewer

comment:1 Changed 6 years ago by christophe.pradal@…

libPyQGLViewer is a new port (#40741)

comment:2 Changed 6 years ago by ryandesign (Ryan Schmidt)

Keywords: python graphics removed
Port: py-PyQGLViewer added

Thanks. Some observations:

  • Since you are not a committer, the maintainers line must list your complete email address in our obfuscated host:user format.
  • "eq" should be used for string comparisons instead of "!=".
  • configure.pre_args is meant only for specifying the prefix; other arguments should go in configure.args.
  • "-I /opt/X11/include" should not be specified; MacPorts ports shall not use XQuartz or other non-MacPorts X11 implementations. If this port needs something from X11, it should declare a dependency on the appropriate xorg port.

Changed 6 years ago by christophe.pradal@…

Attachment: Portfile.2 added

New Portfile replacing the old one

comment:3 in reply to:  2 Changed 6 years ago by christophe.pradal@…

Replying to ryandesign@…:

Thanks a lot for the very fast review. I have fixed the errors in the file Portfile.2

Thanks. Some observations:

  • Since you are not a committer, the maintainers line must list your complete email address in our obfuscated host:user format.

Done: Change pradal into inria.fr:christophe.pradal

  • "eq" should be used for string comparisons instead of "!=".

Done. Change != into ne

  • configure.pre_args is meant only for specifying the prefix; other arguments should go in configure.args.

Done. To remove the --prefix in the configure, I let the configure.pre_args empty. Other args are defined in configure.args

  • "-I /opt/X11/include" should not be specified; MacPorts ports shall not use XQuartz or other non-MacPorts X11 implementations. If this port needs something from X11, it should declare a dependency on the appropriate xorg port.

Fixed. X11 is only needed with qt4-x11 and is not used currently.

comment:4 Changed 6 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

Assuming it builds, I'll commit this with some changes, including:

  • removed unnecessary distname line which made this an undesirable unversioned distfile
  • removed unnecessary "python.default_version 27" line (that's the default)
  • used ${python.bin} in configure.cmd instead of recreating its value
  • adjusted spacing to conform to modeline (indents at multiples of 4 spaces)
  • adjusted livecheck, though it doesn't work; fixing it can be grouped into #40790

comment:5 Changed 6 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed
  • Correction: distname line was still needed, but needed the version number added.
  • Fixed universal build by clearing configure.universal_args.
  • Fixed to actually do the building during the build phase instead of the destroot phase by fixing build.target.

Committed in r112343.

comment:6 Changed 6 years ago by ryandesign (Ryan Schmidt)

It failed to build on the buildbots because GL.h wasn't found. Added mesa dependency in r112348. Since it didn't appear to link with the GL library, I just made it a build dependency.

Note: See TracTickets for help on using tickets.