Opened 7 years ago

Closed 7 years ago

#40768 closed enhancement (fixed)

saga: use the wxWidgets PortGroup

Reported by: mojca (Mojca Miklavec) Owned by: Veence (Vincent)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: saga

Description

I would like to request the usage of the wxWidgets PortGroup for saga.

Additionally please submit an upstream request to use wxwin.m4 to determine the right wx-config rather than "hardcoding" it.

The patch also adds a few extra spaces, patches Makefile.am instead of Makefile (if you ever stop running autofoo tools, you might need to change that back to fixing Makefile, but let's hope that the upstream will properly fix the functionality by then).

There is no need to hardcode wxWidgets version and there is no need to add additional include flags. Those were only needed because wx-config was not found at first.

Attachments (1)

saga-wxwidgets-portgroup.diff (2.4 KB) - added by mojca (Mojca Miklavec) 7 years ago.

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by mojca (Mojca Miklavec)

comment:1 Changed 7 years ago by mojca (Mojca Miklavec)

Disclaimer: I didn't test the software in any way. Please first make sure first that my modifications actually work.

comment:2 Changed 7 years ago by mojca (Mojca Miklavec)

Resolution: fixed
Status: newclosed

Committed in r113330 as maintainer timeout. (See also the duplicate #41353.)

Note: See TracTickets for help on using tickets.