Opened 9 years ago
Closed 9 years ago
#41143 closed defect (fixed)
ffmpeg STILL does not build under PPC Tiger!
| Reported by: | ultrajoe@… | Owned by: | dbevans (David B. Evans) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.2.1 |
| Keywords: | Cc: | jeremyhu (Jeremy Huddleston Sequoia), neverpanic (Clemens Lang), cooljeanius (Eric Gallager) | |
| Port: | ffmpeg, ffmpeg-devel |
Description (last modified by neverpanic (Clemens Lang))
In spite of the comments in bug #39442, ffmpeg still does not build under Tiger.
The patch file (another copy of which is attached here) notes the removal of configuring libbluray and removing the dependency to the library. The updated Portfile only removes the configure.arg in line 100, not the dependency.
Attachments (4)
Change History (20)
comment:1 Changed 9 years ago by ultrajoe@…
comment:2 Changed 9 years ago by neverpanic (Clemens Lang)
| Cc: | jeremyhu@… added |
|---|---|
| Description: | modified (diff) |
| Owner: | changed from macports-tickets@… to devans@… |
comment:3 Changed 9 years ago by neverpanic (Clemens Lang)
It seems to me that r107091 did correctly add depends_lib-delete port:libblueray (see source:trunk/dports/multimedia/ffmpeg/Portfile@112864:99#L80 for ffmpeg and source:trunk/dports/multimedia/ffmpeg-devel/Portfile@112864:105#L80 for ffmpeg-devel).
Since I don't have access to a Tiger machine, I cannot test this, but if ffmpeg doesn't build for you it doesn't seem this is the cause. Please provide the main.log of a clean failed build and the output of port -v deps ffmpeg on your machine (which should correctly not list libbluray).
comment:4 Changed 9 years ago by neverpanic (Clemens Lang)
| Cc: | cal@… added |
|---|
comment:5 Changed 9 years ago by dbevans (David B. Evans)
| Status: | new → assigned |
|---|
comment:6 Changed 9 years ago by dbevans (David B. Evans)
I've committed a fix (hopefully) in r112868 that appends --disable-libbluray as well as just removing the --enable-libbluray. This should keep it from trying to build with libbluray even if you have it installed.
Flying blind here as I don't have a PPC machine any more either so please let me know if this works or something else needs to be done.
As mentioned above, if there is a problem, submitting a full build log would help immensely. Thanks.
comment:8 Changed 9 years ago by ultrajoe@…
OK, I'm an idiot. The problem is not the dependency, but that it somehow needs configure.args-append --disable-libbluray. That is in my patch file, but missing from the Portfile. (Disclaimer: I have not tried the revision devans@… committed, though it sounds like that also does the trick.)
Please accept my apologies. Health crises have me extremely stressed right now.
comment:9 Changed 9 years ago by neverpanic (Clemens Lang)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:10 Changed 9 years ago by ultrajoe@…
Nope, r112868 does not fix it. I'm attaching logs as soon as I finish typing this.
I have a hunch, though, what the problem is. I suspect the revisions around line 100 is actually too early, since the full config.args list follows that conditional. I have modified the Portfile to place the test after the list of config.args and am attempting a reinstall now.
Changed 9 years ago by ultrajoe@…
| Attachment: | config.log added |
|---|
Revised config.log with r112868 in place
comment:11 Changed 9 years ago by ultrajoe@…
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
comment:12 follow-ups: 14 15 Changed 9 years ago by neverpanic (Clemens Lang)
You're right. That also breaks --disable-asm, that is in the same block and was supposed to work. Since this is an obvious mistake and the consequences are limited to old systems, I've taken advantage of openmaintainer policies and changed that in r112948.
Let me know if that works for you.
comment:13 Changed 9 years ago by neverpanic (Clemens Lang)
Of course, if ffmpeg meanwhile stopped supporting --disable-asm, this will break the build again. Let us know if that's the case.
Changed 9 years ago by ultrajoe@…
| Attachment: | PortFile-ffmpeg.diff added |
|---|
Success''' The order is important. This is the revised patch file for r112868 to make it work under Tiger!
comment:14 Changed 9 years ago by ultrajoe@…
Replying to cal@…:
You're right. That also breaks
--disable-asm, that is in the same block and was supposed to work. Since this is an obvious mistake and the consequences are limited to old systems, I've taken advantage of openmaintainer policies and changed that in r112948.Let me know if that works for you.
Sorry, cal. We were working in parallel. My patch dropped it below the post-destroot section, but where you put it should work as well. I'll verify that, though, just in case.
comment:15 Changed 9 years ago by ultrajoe@…
Replying to cal@…:
You're right. That also breaks
--disable-asm, that is in the same block and was supposed to work. Since this is an obvious mistake and the consequences are limited to old systems, I've taken advantage of openmaintainer policies and changed that in r112948.Let me know if that works for you.
r112948 is good!
comment:16 Changed 9 years ago by neverpanic (Clemens Lang)
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
The
depends_lib-deleteline is what's missing, I believe.By the way, if there's really a need for the attitude seen in bug #39442, then maybe it is time to stop "helping" with bug reports here.