nip2 update to 7.38.3 - fixes build on mavericks ( 7.26.3_1 fails under Mavericks)

[Schamschula (Marius Schamschula)]

I get the following error in building nip2 7.26.3_1 under Mavericks:

/usr/bin/clang -DHAVE_CONFIG_H -I. -I.. -I/opt/local/include  -I/opt/local/include/graphviz    -I/opt/local/include  -D_REENTRANT -DMAGICKCORE_HDRI_ENABLE=0 -DMAGICKCORE_QUANTUM_DEPTH=16 -DMAGICKCORE_HDRI_ENABLE=0 -DMAGICKCORE_QUANTUM_DEPTH=16 -D_THREAD_SAFE -D_REENTRANT -I/opt/local/include/gtk-2.0 -I/opt/local/lib/gtk-2.0/include -I/opt/local/include/pango-1.0 -I/opt/local/include/gio-unix-2.0/ -I/opt/local/include -I/opt/local/include/cairo -I/opt/local/include/atk-1.0 -I/opt/local/include/cairo -I/opt/local/include/pixman-1 -I/opt/local/include -I/opt/local/include/gdk-pixbuf-2.0 -I/opt/local/include/libpng15 -I/opt/local/include -I/opt/local/include/libxml2 -I/opt/local/include -I/opt/local/include/ImageMagick-6 -I/opt/local/include/orc-0.4 -I/opt/local/include -I/opt/local/include/OpenEXR -I/opt/local/include -I/opt/local/include/pango-1.0 -I/opt/local/include/harfbuzz -I/opt/local/include/pango-1.0 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include/freetype2 -I/opt/local/include -I/opt/local/include/freetype2 -I/opt/local/include -I/opt/local/include/libpng15 -I/opt/local/include  -DG_DISABLE_CAST_CHECKS    -I/opt/local/include  -pipe -Os -arch x86_64 -MT nip2-iimageview.o -MD -MP -MF .deps/nip2-iimageview.Tpo -c -o nip2-iimageview.o `test -f 'iimageview.c' || echo './'`iimageview.c
graphwindow.c:263:38: error: too few arguments to function call, expected 2, have 1
        graphwindow->graph = agread( of->fp );
                            ~~~~~~         ^
/opt/local/include/graphviz/cgraph.h:268:1: note: 'agread' declared here
extern Agraph_t *agread(void *chan, Agdisc_t * disc);
^
1 error generated.
make[3]: *** [nip2-graphwindow.o] Error 1

Full main.log attached

[Schamschula (Marius Schamschula)]

I updated the Portfile to the current version of nip2: 7.36.4. This builds fine, even under Mavericks.

[Schamschula (Marius Schamschula)]

I have updated nip2 to @7.38.1. Also fixed depends_lib from goffice to goffice08, as goffice now requires gtk+3.

[kurthindenburg (Kurt Hindenburg)]

Cc Me!

[kurthindenburg (Kurt Hindenburg)]

Thanks I updated to 7.38.3 and it builds on mavericks - why change goffice to goffice08?

[jcupitt (John Cupitt)]

goffice is gtk+3 and nip2 is still a gtk+2 program. goffice08 is the last goffice that builds with gtk+2.

nip2 will be moving to gtk+3, but not for another year or so.

[kurthindenburg (Kurt Hindenburg)]

patch for latest nips2

[kurthindenburg (Kurt Hindenburg)]

It builds/installs but it won't run

Program received signal SIGABRT, Aborted.
0x00007fff97f2b866 in __pthread_kill ()

[kurthindenburg (Kurt Hindenburg)]

It works if you run from source folder ./src/nip2 but not from a 'make install'

[kurthindenburg (Kurt Hindenburg)]

The issue appears to be this memccpy in src/tools:

/* Strip underscores (they mark mnemonics). Can't use$
 * strrcpy(), we have overlapping blocks.$
*/$

im_strncpy( value, toolitem->label, MAX_NAME );$
for( i = 0; value[i]; i++ )$
if( value[i] == '_' )$
memccpy( value + i, value + i + 1,$
0, MAX_NAME - i );

[kurthindenburg (Kurt Hindenburg)]

Attempt to replace memccpy

[jcupitt (John Cupitt)]

Thanks for finding this khindenburg. I've made a 7.38.4 which incorporates a version of your patch:

​https://github.com/jcupitt/nip2/commit/74454e179b6bf961eaa697ae691cd66b4347adb0

I was stupidly using memccpy() on overlapping memory areas, which is undefined.

#44090 has a portfile update which switches to this version. I think this closes both these tickets.

[ryandesign (Ryan Carsten Schmidt)]

Superseded by #44090.