netcdf @4.3.0: build fails on snow leopard

[mndavidoff (Monte Davidoff)]

Building netcdf 4.3.0 fails on Mac OS X 10.6.8. The previous version (netcdf @4.2.1.1_3) built successfully.

$ sudo port -vs install netcdf +dap +netcdf4
...
/bin/sh ../libtool  --tag=CC   --mode=compile /usr/bin/gcc-4.2 -DHAVE_CONFIG_H -I. -I..  -I../include -I../oc2  -I../libsrc4 -I/opt/local/include -DNDEBUG  -pipe -Os -fno-common -arch x86_64 -MT libdap2_la-daputil.lo -MD -MP -MF .deps/libdap2_la-daputil.Tpo -c -o libdap2_la-daputil.lo `test -f 'daputil.c' || echo './'`daputil.c
libtool: compile:  /usr/bin/gcc-4.2 -DHAVE_CONFIG_H -I. -I.. -I../include -I../oc2 -I../libsrc4 -I/opt/local/include -DNDEBUG -pipe -Os -fno-common -arch x86_64 -MT libdap2_la-daputil.lo -MD -MP -MF .deps/libdap2_la-daputil.Tpo -c daputil.c  -fno-common -DPIC -o .libs/libdap2_la-daputil.o
In file included from ncdap3.h:12,
                 from daputil.c:16:
/usr/include/unistd.h:117: error: two or more data types in declaration specifiers
make[2]: *** [libdap2_la-daputil.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
libtool: compile:  /usr/bin/gcc-4.2 -DHAVE_CONFIG_H -I. -I.. -I../include -I../oc2 -I../libsrc4 -I/opt/local/include -DNDEBUG -pipe -Os -fno-common -arch x86_64 -MT libdap2_la-dapodom.lo -MD -MP -MF .deps/libdap2_la-dapodom.Tpo -c dapodom.c -o libdap2_la-dapodom.o >/dev/null 2>&1
mv -f .deps/libdap2_la-dapodom.Tpo .deps/libdap2_la-dapodom.Plo
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_netcdf/netcdf/work/netcdf-4.3.0/libdap2'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_netcdf/netcdf/work/netcdf-4.3.0'
make: *** [all] Error 2
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_netcdf/netcdf/work/netcdf-4.3.0'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_netcdf/netcdf/work/netcdf-4.3.0" && /usr/bin/make -j2 -w all 
Exit code: 2
Error: org.macports.build for port netcdf returned: command execution failed
Warning: targets not executed for netcdf: org.macports.activate org.macports.build org.macports.destroot org.macports.install
Please see the log file for port netcdf for details:
    /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_netcdf/netcdf/main.log
To report a bug, follow the instructions in the guide:
    http://guide.macports.org/#project.tickets
Error: Processing of port netcdf failed

[larryv (Lawrence Velázquez)]

Has duplicate #41210.

[tenomoto (Takeshi Enomoto)]

It seems that this has been a known but unaddressed issue ​http://www.unidata.ucar.edu/support/help/MailArchives/netcdf/msg11876.html. The build fails because oc.h is included twice in ncdap3.h and daputil.c. Fixed in r112984. I'll report this upstream.