Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#41226 closed update (fixed)

gmt4 @4.5.9_0: update to 4.5.11

Reported by: florian@… Owned by: tenomoto (Takeshi Enomoto)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc:
Port: gmt4

Description

Attached is the Portfile patch to upgrade gmt4 from 4.5.9 to 4.5.11.

Attachments (4)

Portfile-gmt4.diff (4.2 KB) - added by florian@… 10 years ago.
Portfile patch for gmt4
patch-ps2raster.diff (415 bytes) - added by florian@… 10 years ago.
Patchfile fixes Mavericks bug
patch-ps2raster.2.diff (415 bytes) - added by florian@… 10 years ago.
Patchfile fixes Mavericks bug
patch-grdvector.diff (1.2 KB) - added by florian@… 10 years ago.
Patchfile fixes Mavericks bug

Download all attachments as: .zip

Change History (15)

comment:1 Changed 10 years ago by larryv (Lawrence Velázquez)

Cc: takeshi@… removed
Keywords: maintainer added
Owner: changed from macports-tickets@… to takeshi@…
Summary: gmt4 update to 4.5.11gmt4 @4.5.9_0: update to 4.5.11
Version: 2.2.1

Changed 10 years ago by florian@…

Attachment: Portfile-gmt4.diff added

Portfile patch for gmt4

Changed 10 years ago by florian@…

Attachment: patch-ps2raster.diff added

Patchfile fixes Mavericks bug

Changed 10 years ago by florian@…

Attachment: patch-ps2raster.2.diff added

Patchfile fixes Mavericks bug

Changed 10 years ago by florian@…

Attachment: patch-grdvector.diff added

Patchfile fixes Mavericks bug

comment:2 Changed 10 years ago by florian@…

Unfortunately the first Mavericks bugs appeared, so I amended the Portfile patch and added two patchfiles.

comment:3 Changed 10 years ago by tenomoto (Takeshi Enomoto)

Committed in r113124. BTW, the bug on strcpy has been annoying me in ncarg port. I am excited see a solution! Did you find the fix? If you know some other reference, let me know.

comment:4 Changed 10 years ago by tenomoto (Takeshi Enomoto)

Resolution: fixed
Status: newclosed

comment:5 Changed 10 years ago by tenomoto (Takeshi Enomoto)

Resolution: fixed
Status: closedreopened

I got buildbot failures... It compiled OK on Mavericks.

comment:6 Changed 10 years ago by tenomoto (Takeshi Enomoto)

Resolution: fixed
Status: reopenedclosed

Forgot to add patches. Committed in r113126.

comment:7 Changed 10 years ago by florian@…

Thanks. The issue with strcpy is actually not a Mavericks bug but a general issue because strcpy's behavior is undefined with overlapping strings (http://pubs.opengroup.org/onlinepubs/009695399/functions/strcpy.html). The "fix" in our case was to test whether the arguments of strcpy are the same (pointers equal). You could create a macro wrapper as such and include it early in the ncarg code:

#define strcpy(a, b) {if (a!=b) strcpy (a, b)}

but this only catches identical pointers and not string overlaps. So you may be lucky or you may not.

Btw, where would I see buildbot failures and logs?

comment:8 Changed 10 years ago by tenomoto (Takeshi Enomoto)

Go to https://build.macports.org/waterfall and click compile > stdio of the submitted changes.

comment:9 Changed 10 years ago by florian@…

Great, thanks! Oh, and I just noted that I accidentally uploaded attachment:patch-ps2raster.diff twice. You can remove gmt4/files/patch-ps2raster.2.diff from svn.

comment:10 in reply to:  7 Changed 10 years ago by tenomoto (Takeshi Enomoto)

The issue with strcpy is actually not a Mavericks bug but a general issue because strcpy's behavior is undefined with overlapping strings

Wow C is difficult!

I deleted the duplicate patch in r113127. Thanks.

comment:11 Changed 10 years ago by florian@…

Thank you too for committing all the GMT relates changes.

Note: See TracTickets for help on using tickets.