libbonoboui @2.24.5: error: format string is not a string literal [-Werror,-Wformat-nonliteral]

[allamistakeo18@…]

I'm trying to install gnucash on Mavericks, after upgrading from Lion.

My first attempt failed when building pulseaudio returned an error, as documented in this other ticket: #41415

So now, I just renamed my /opt/ and /Applications/MacPorts/ folders, reinstalled MacPorts from scratch (instead of attempting to upgrade my Lion installation), and when I try to install gnucash, this time it fails to build libbonoboui. See attached log file.

[ryandesign (Ryan Carsten Schmidt)]

This was not a clean attempt. Please ​clean and try again.

[rjderosa (Robert De Rosa)]

clean attempt

[rjderosa (Robert De Rosa)]

Replying to ryandesign@…:

This was not a clean attempt. Please ​clean and try again.

It doesn't build on Mavericks after cleaning.

[rjderosa (Robert De Rosa)]

I got it to build by removing the "-Werror=format=2" flag from the Makefile in the libbonoboui/work/libbonoboui-2.24.5/bonobo directory.

Probably a very dirty way to get it to build, but gnucash doesn't seem to complain (yet).

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #41584.

[allamistakeo18@…]

Replying to rderosa86@…:

I got it to build by removing the "-Werror=format=2" flag from the Makefile in the libbonoboui/work/libbonoboui-2.24.5/bonobo directory.

Can you please clarify what you did exactly? I removed that flag from the Makefile but I still can't get it to build.

[jmroot (Joshua Root)]

Some of those warning flags don't occur anywhere in the source, so I would guess they're coming from the .pc file of one or more dependencies. Putting -Werror in flags intended to be used by other programs is, of course, a really bad idea.

[jmroot (Joshua Root)]

They don't seem to be coming from pkg-config either. Maybe the autoreconf is adding them?

[MartinBuchmann (Martin Buchmann)]

Cc Me!

[rjderosa (Robert De Rosa)]

Replying to allamistakeo18@…:

Replying to rderosa86@…:

I got it to build by removing the "-Werror=format=2" flag from the Makefile in the libbonoboui/work/libbonoboui-2.24.5/bonobo directory.

Can you please clarify what you did exactly? I removed that flag from the Makefile but I still can't get it to build.

I'm not sure how I could clarify that further. I think there is only one instance of -Werror=format=2 flag in the makefile.

[allamistakeo18@…]

Replying to rderosa86@…:

I'm not sure how I could clarify that further. I think there is only one instance of -Werror=format=2 flag in the makefile.

Got it. I was editing the wrong Makefile. Now I also got it to compile.

[onurdomanic@…]

Cc Me!

[rmonv@…]

Got it to compile by editing the configure file that generates the Makefiles in the same way as rderosa86 did

/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_gnome_libbonoboui/libbonoboui/work//libbonoboui-2.24.5/configure

[bouttier__macports@…]

Cc Me!

[kajh]

Cc Me!

[4eppelin@…]

Cc Me!

[kajh]

Cc Me!

[kajh]

Cc Me!

[josephsacco]

GCC is smart enough not to issue a warning when calling a printf function using a va_list; clang is not. See:

​http://comments.gmane.org/gmane.linux.arch.pacman.devel/10278

for a possible work-around.

Needless to say, libbonoboui does build using gcc-4.8.x

-Joseph

[christian@…]

I got it to compile with the attached patch. The solution comes form an answer to the post linked by drjesacco above.

[jgmath2000@…]

Cc Me!

[dbevans (David B. Evans)]

Fix committed in r115037