#41617 closed defect (fixed)
tigervnc @1.2.0_0: patch filename has wrong case
| Reported by: | ballapete (Peter "Pete" Dyballa) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.2.1 |
| Keywords: | Cc: | ryandesign (Ryan Carsten Schmidt), larryv (Lawrence Velázquez) | |
| Port: | tigervnc |
Description
Trying to build TigerVNC on PPC Leopard fails because the source archive (I fetched it manually from SourceForge) and the patch files cannot be downloaded. For example:
---> Attempting to fetch patch-common-fltk-FL-mac.h.diff from http://ufpr.dl.sourceforge.net/project/tigervnc/tigervnc/1.2.0
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 409 0 0 0 0 0 0 --:--:-- 0:00:41 --:--:-- 0
DEBUG: Fetching distfile failed: The requested URL returned error: 404
Attachments (1)
Change History (11)
Changed 10 years ago by ballapete (Peter "Pete" Dyballa)
comment:1 follow-up: 2 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | ryandesign@… added |
|---|---|
| Resolution: | → invalid |
| Status: | new → closed |
The patch files are already in the files directory.
comment:2 follow-up: 3 Changed 10 years ago by ballapete (Peter "Pete" Dyballa)
Replying to ryandesign@…:
The patch files are already in the files directory.
Indeed, they are there:
pete 208 /\ ls -lR /opt/local/var/macports/sources/lil.fr.rsync.macports.org/release/tarballs/ports/x11/tigervnc total 16 -rw-r--r-- 1 root wheel 2549 22 Okt 12:02 Portfile drwxr-xr-x 2 root wheel 204 15 Jul 18:04 files lrwxr-xr-x 1 root wheel 137 30 Nov 14:03 work -> /opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_x11_tigervnc/tigervnc/work /opt/local/var/macports/sources/lil.fr.rsync.macports.org/release/tarballs/ports/x11/tigervnc/files: total 48 -rw-r--r-- 1 root wheel 487 15 Jul 18:04 patch-common-fltk-FL-mac.H.diff -rw-r--r-- 1 root wheel 449 15 Jul 18:04 patch-common-fltk-src-Makefile.diff -rw-r--r-- 1 root wheel 961 15 Jul 18:04 patch-common-fltk-src-filename_list.cxx.diff -rw-r--r-- 1 root wheel 10016 15 Jul 18:04 patch-gnutls-3.diff
So why is port not using them?
comment:3 follow-up: 9 Changed 10 years ago by larryv (Lawrence Velázquez)
The port is looking for a patch ending in .h.diff, while the existing patch ends in .H.diff. I presume your filesystem is case-sensitive.
I corrected the filename case in r114192.
comment:4 Changed 10 years ago by larryv (Lawrence Velázquez)
| Resolution: | invalid |
|---|---|
| Status: | closed → reopened |
| Summary: | TigerVNC @1.2.0 cannot be built because PATCH files are not available → tigervnc @1.2.0_0: patch filename has wrong case |
comment:5 Changed 10 years ago by larryv (Lawrence Velázquez)
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
comment:6 follow-up: 7 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | larryv@… added |
|---|
Thanks, this should work, but the name of the patchfile was correct, because the file being patched is mac.H not mac.h, so the better fix would have been to correct the patchfile name in the portfile's patchfiles line.
comment:7 Changed 10 years ago by larryv (Lawrence Velázquez)
You’re right; I didn’t check the patch contents. Sloppy. r114194 should take care of it.
comment:8 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
No no, you're awesome for identifying and fixing the problem :)
comment:9 Changed 10 years ago by ballapete (Peter "Pete" Dyballa)
Replying to larryv@…:
The port is looking for a patch ending in
.h.diff, while the existing patch ends in.H.diff. I presume your filesystem is case-sensitive.
Yes, of course! (I come from UNIX, not ENIAC and FORTRAN.)
main.log