Opened 7 years ago

Closed 7 years ago

#41640 closed defect (fixed)

VLC, VLC-devel: fails to build with freetype 2.5.1

Reported by: ctreleaven (Craig Treleaven) Owned by: jeremyhu (Jeremy Huddleston Sequoia)
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: Cc: ryandesign (Ryan Schmidt), dbevans (David B. Evans)
Port: VLC, VLC-devel

Description

Freetype changed the layout of its include files and VLC is using an obsolete #include:

:info:build freetype.c:93:10: fatal error: 'freetype/ftsynth.h' file not found
:info:build #include <freetype/ftsynth.h>
:info:build          ^

Note, it is not possible to set the owner field when creating a ticket (at least for my ID). Thus I've put Jeremy on the CC list.

Attachments (1)

VLC freetype build fail 2013Dec01.log (428.7 KB) - added by ctreleaven (Craig Treleaven) 7 years ago.
see line 5717

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by ctreleaven (Craig Treleaven)

see line 5717

comment:1 Changed 7 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added; jeremyhu@… removed
Keywords: freetype removed
Owner: changed from macports-tickets@… to jeremyhu@…
Port: VLC VLC-devel added; vlc removed
Summary: VLC fails to build with freetype 2.5.1VLC, VLC-devel: fails to build with freetype 2.5.1

comment:2 Changed 7 years ago by ctreleaven (Craig Treleaven)

Seems to have been reported and a fix committed upstream:

https://trac.videolan.org/vlc/ticket/10019

Pretty trivial:

http://git.videolan.org/?p=vlc.git;a=commit;h=c5b2b0a284ba6b544646f3a205aa1a2e1117d431

From c5b2b0a284ba6b544646f3a205aa1a2e1117d431 Mon Sep 17 00:00:00 2001
From: Jean-Baptiste Kempf <jb@videolan.org>
Date: Mon, 2 Dec 2013 17:32:07 +0100
Subject: [PATCH] Freetype: fix compilation with 2.5.1

Close #10019
---
 modules/text_renderer/freetype.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/modules/text_renderer/freetype.c b/modules/text_renderer/freetype.c
index bd78c0d..baeeb96 100644
--- a/modules/text_renderer/freetype.c
+++ b/modules/text_renderer/freetype.c
@@ -88,10 +88,11 @@
 #endif
 
 /* Freetype */
-#include <freetype/ftsynth.h>
+#include <ft2build.h>
 #include FT_FREETYPE_H
 #include FT_GLYPH_H
 #include FT_STROKER_H
+#include FT_SYNTHESIS_H
 
 #define FT_FLOOR(X)     ((X & -64) >> 6)
 #define FT_CEIL(X)      (((X + 63) & -64) >> 6)
-- 
1.7.10.4

comment:3 Changed 7 years ago by ryandesign (Ryan Schmidt)

Cc: devans@… added
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.