Opened 7 years ago

Closed 7 years ago

#41663 closed defect (fixed)

webkit-gtk fails to build: no member named RedirectedXCompositeWindow

Reported by: gthb (Gunnlaugur Thor Briem) Owned by: jeremyhu (Jeremy Huddleston Sequoia)
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: Cc: dbevans (David B. Evans), cooljeanius (Eric Gallager), AP1010, zoleg@…, soriyath@…, macports@…, Greisby (Greisberger Christophe)
Port: webkit-gtk

Description

Salient bit from main.log:

:info:build ./Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContext.h:79:21: error: no member named 'RedirectedXCompositeWindow' in namespace 'WebCore'
:info:build     OwnPtr<WebCore::RedirectedXCompositeWindow> m_redirectedWindow;
:info:build            ~~~~~~~~~^

Attachments (2)

main.log (16.5 MB) - added by gthb (Gunnlaugur Thor Briem) 7 years ago.
main.log
webkit-gtk_mavericks.diff (978 bytes) - added by Greisby (Greisberger Christophe) 7 years ago.
Portfile patch

Change History (16)

Changed 7 years ago by gthb (Gunnlaugur Thor Briem)

Attachment: main.log added

main.log

comment:1 Changed 7 years ago by gthb (Gunnlaugur Thor Briem)

Whoops, failure is actually in webkit-gtk @2.2.2+video+quartz but I don't have permission to change the ticket title and CC (to add jeremyhu@…), nor to close.

comment:2 Changed 7 years ago by mf2k (Frank Schima)

Owner: changed from macports-tickets@… to jeremyhu@…
Port: webkit-gtk added; gimp2 removed

comment:3 Changed 7 years ago by mf2k (Frank Schima)

Summary: gimp2 @2.8.10_0+python27+quartz fails to build: no member named RedirectedXCompositeWindowwebkit-gtk fails to build: no member named RedirectedXCompositeWindow

comment:4 Changed 7 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:5 Changed 7 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Status: newassigned

Looks like another case where they assume GTK means X11. If someone provides a patch, I'll merge it in.

comment:6 Changed 7 years ago by AP1010

Cc: arthur@… added

Cc Me!

comment:7 Changed 7 years ago by zoleg@…

Cc: zoleg@… added

Cc Me!

comment:8 Changed 7 years ago by soriyath@…

Cc: soriyath@… added

Cc Me!

comment:9 Changed 7 years ago by macports@…

Cc: macports@… added

Cc Me!

comment:10 Changed 7 years ago by Greisby (Greisberger Christophe)

Cc: greisberger@… added

Cc Me!

comment:11 Changed 7 years ago by Greisby (Greisberger Christophe)

A first step is to disable accelerated compositing in the Portfile:

variant quartz {
    configure.args-append --with-target=quartz
    configure.args-append --disable-accelerated-compositing

The compilation works, but the link fails with the following error:

:info:build duplicate symbol __ZN7WebCore13PluginPackage15determineQuirksERKN3WTF6
StringE in:
:info:build     ./.libs/libWebCore.a(libWebCore_la-P)
:info:build ld: 1 duplicate symbol for architecture x86_64
:info:build clang: error: linker command failed with exit code 1 (use -v to see in
vocation)
:info:build make[1]: *** [libwebkitgtk-1.0.la] Error 1

I have no idea why...

comment:12 in reply to:  11 Changed 7 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Replying to greisberger@…:

The compilation works, but the link fails with the following error:

:info:build duplicate symbol __ZN7WebCore13PluginPackage15determineQuirksERKN3WTF6
StringE in:
:info:build     ./.libs/libWebCore.a(libWebCore_la-P)
:info:build ld: 1 duplicate symbol for architecture x86_64
:info:build clang: error: linker command failed with exit code 1 (use -v to see in
vocation)
:info:build make[1]: *** [libwebkitgtk-1.0.la] Error 1

I have no idea why...

#42010

comment:13 Changed 7 years ago by Greisby (Greisberger Christophe)

The last selfupdate fixed the link error (port 2.2.3 revision 1).
The patch I attached works now.

I attach it again with a small change that makes it to apply only on Mavericks, since I have no machine to test if it is needed for older OS versions.

Changed 7 years ago by Greisby (Greisberger Christophe)

Attachment: webkit-gtk_mavericks.diff added

Portfile patch

comment:14 Changed 7 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.