Opened 10 years ago

Closed 6 years ago

#41770 closed defect (fixed)

VisualBoyAdvance @1.7.2_2: error: redefinition of 'i'

Reported by: christian_luca@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: Cc: ryandesign (Ryan Carsten Schmidt)
Port: VisualBoyAdvance

Description

building Visual Boy Advance fails on my 10.8.5 with Xcode version 5.0.2.

I had a short look inside the attached log file. Inside debugger.cpp 'int i' is redefined 3 times…

do you have an idea how to compile this? (This is also the case for src'es I've found on source forge, so I think some-how it should work. But with this sources I issued a problem that seems to be fixed in mac ports ) :-D

Attachments (1)

main.log (111.5 KB) - added by christian_luca@… 10 years ago.

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by christian_luca@…

Attachment: main.log added

comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added
Owner: changed from macports-tickets@… to jtonio@…
Port: VisualBoyAdvance added
Summary: VisualBoyAdvance @1.7.2_2 - build failureVisualBoyAdvance @1.7.2_2: error: redefinition of 'i'

Older compilers were less picky about these problems. gcc 4.2 for example does not complain about this. But we now use clang, and it does complain, and is right to do so; this is an error that should be fixed.

However once this is fixed, you'll run into another problem: #37561.

VisualBoy Advance has not had a new release since 2004, so it appears to be a dead project. Maybe someone has already written a patch to fix these problems.

comment:2 Changed 10 years ago by christian_luca@…

thanks for the quick response.

Oh, yes… I was quite suprised seeing that last release was on 2004… I just did some google research and found mac boy advance (http://sourceforge.net/projects/macboyadvance/) and VBA-M (http://sourceforge.net/projects/vbam/). Both were updated this year so those might be candidates :-D

I will do some tests with mac boy advance and report my results here ;-)

Best regards

comment:3 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Let us know if one of them works. If so, we can try to write ports for one or both of them—or you can write them, if you'd like.

comment:4 Changed 10 years ago by christian_luca@…

I did not compile Mac Boy Advance yet because its getting quite late - I just took the prebuilt executable from sourceforge.net which runs quite well…

In case I will find some time within the next days I will try to compile it as well and report my success here ;-)

PS: I guess writing a port for mac boy advance is a good idea as it seems to be "optimized" for Mac OS. Personally I do not have experience in writing mac port wrapper scripts so it might be fastest if this is done by one of you ;-)

comment:5 Changed 10 years ago by christian_luca@…

hello together,

I did not compile mentioned forks of the Visual Boy Advance projects but I browsed their sources and like to share the current result with you. One thing that seems to be same for both projects is that they do not use gnu autoconf scripts to build the makefile.

MacBoyAdvance: Seems to be build through a xcode-project. If there is a possibility to compile targets of Xcode projects from the command line this one is probably quite easy to port as its dependencies and most source code are still the original ones. http://sourceforge.net/p/macboyadvance/code/HEAD/tree/

VBA-M: This project still seems to be very active. Project configuration is done via CMake - so I expect writing a wrapper script for this one will be much more complicated (did not run the CMake script yet). Additionally I think there are new dependencies (for example wxWidgets). On the other hand (as already mentioned) even this year there were lots of improvements done to the project. http://sourceforge.net/p/vbam/code/HEAD/tree/

I hope this pieces of information can help...

Best Regards

comment:6 in reply to:  5 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to christian_luca@…:

MacBoyAdvance: Seems to be build through a xcode-project. If there is a possibility to compile targets of Xcode projects from the command line this one is probably quite easy to port as its dependencies and most source code are still the original ones. http://sourceforge.net/p/macboyadvance/code/HEAD/tree/

Xcode-based projects are supported in MacPorts. Using the xcode portgroup is usually the simplest way.

VBA-M: This project still seems to be very active. Project configuration is done via CMake - so I expect writing a wrapper script for this one will be much more complicated (did not run the CMake script yet). Additionally I think there are new dependencies (for example wxWidgets). On the other hand (as already mentioned) even this year there were lots of improvements done to the project. http://sourceforge.net/p/vbam/code/HEAD/tree/

Using cmake-based projects in MacPorts is not usually problematic; we have the cmake portgroup to handle this. The wxWidgets ports in MacPorts were recently overhauled and should be working ok; we now have a wxWidgets portgroup which ports that want to use wxWidgets can use.

comment:7 Changed 6 years ago by kurthindenburg (Kurt Hindenburg)

Owner: jtonio@… deleted
Status: newassigned

comment:8 Changed 6 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: set to ryandesign
Resolution: fixed
Status: assignedclosed

In 44e89072080542c252438ee23258638769f6fc9e/macports-ports (master):

VisualBoyAdvance: Don't redefine i and n

Trying to use the same name for two different variables, twice, can't
have been good. Increase revision to ensure the bad code isn't used
anymore.

Closes: #41770

Note: See TracTickets for help on using tickets.