exo @0.3.107: build fails when libnotify is active

[ryandesign (Ryan Carsten Schmidt)]

exo 0.3.107 fails to build for me on Mavericks when libnotify is active:

main.c:246:71: error: too many arguments to function call, expected 3, have 4
  notification = notify_notification_new (summary, message, opt_icon, NULL);
                 ~~~~~~~~~~~~~~~~~~~~~~~                              ^~~~
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/clang/5.0/include/stddef.h:74:16: note: expanded from macro 'NULL'
#  define NULL ((void*)0)
               ^~~~~~~~~~
/opt/local/include/libnotify/notification.h:114:1: note: 'notify_notification_new' declared here
NotifyNotification *notify_notification_new                  (const char         *summary,
^
1 error generated.

notification.h is provided by libnotify:

$ port provides /opt/local/include/libnotify/notification.h
/opt/local/include/libnotify/notification.h is provided by: libnotify
$ port -v installed libnotify
The following ports are currently installed:
  libnotify @0.7.6_0+universal (active) platform='darwin 13' archs='i386 x86_64'

libnofity is not in exo's dependencies:

$ port rdeps exo | grep libnotify

exo installs fine if I deactivate libnotify first. exo should either indicate this build conflict with the conflicts_build portgroup or should be fixed to install correctly even if libnotify is installed.

[diekhans (Mark Diekhans)]

Cc Me!

[dbevans (David B. Evans)]

This is not really a conflict but opportunistic configuration. exo will configure to provide notifications by default if libnotify is available. Unfortunately it uses the old pre 0.7 API causing the build failure.

Solution is to either update the port to use the current libnotify API or disable notifications. Attached is a patch that does the latter.

[dbevans (David B. Evans)]

Proposed patch for review

[dbevans (David B. Evans)]

Cc Me!

[dbevans (David B. Evans)]

Patch committed, maintainer timeout, to fix build in r118145 but port really should be updated to a more current version, see #41860.