Opened 7 years ago

Closed 6 years ago

#41914 closed update (fixed)

bastet: update to 0.43

Reported by: ryandesign (Ryan Schmidt) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: bastet

Description

$ port livecheck bastet
bastet seems to have been updated (port version: 0.41, new version: 0.43)

Note that 0.43 is a complete rewrite.

Attachments (3)

patch-Makefile.diff (431 bytes) - added by ryandesign (Ryan Schmidt) 7 years ago.
bastet-0.43.diff (2.4 KB) - added by ryandesign (Ryan Schmidt) 7 years ago.
proposed patch
bastet-0.43.1.diff (2.7 KB) - added by ryandesign (Ryan Schmidt) 7 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 7 years ago by ryandesign (Ryan Schmidt)

I've attached a patch of my work so far, but this rewrite still has numerous problems and does not build yet.

comment:2 Changed 7 years ago by ryandesign (Ryan Schmidt)

One problem was mine: I was instructing the Portfile to overwrite the Makefile's LDFLAGS. That's fixed in the new diff attached, and the port installs and works fine on Mac OS X 10.5.

The remaining problem is that 0.43 doesn't build on OS X 10.9 because of libc++. I filed upstream issue 1 for this. The 0.43 rewrite was done in C++, but in 2009, before C++11 was standardized, and uses things from the tr1 section which is not in C++11 and which is not in libc++.

We could commit this update now, and add a patch for the libc++ issues once the developer resolves them.

Changed 7 years ago by ryandesign (Ryan Schmidt)

Attachment: patch-Makefile.diff added

comment:3 Changed 7 years ago by ryandesign (Ryan Schmidt)

The patch also ensures the port is UsingTheRightCompiler and -arch flags, adds a universal variant, indicates the license, and installs the blank scores file in post-activate instead of during the destroot, so that the scores are not cleared when the user upgrades or uninstalls the port. The patch in #41913 should be applied first.

Changed 7 years ago by ryandesign (Ryan Schmidt)

Attachment: bastet-0.43.diff added

proposed patch

comment:4 in reply to:  2 Changed 7 years ago by ryandesign (Ryan Schmidt)

Replying to ryandesign@…:

The remaining problem is that 0.43 doesn't build on OS X 10.9 because of libc++. I filed upstream issue 1 for this. The 0.43 rewrite was done in C++, but in 2009, before C++11 was standardized, and uses things from the tr1 section which is not in C++11 and which is not in libc++.

The developer committed a fix for this, but unfortunately the fix for 10.9 broke it on all earlier OS X versions. I've explained this to the developer; we'll see if a better solution can be found.

comment:5 Changed 7 years ago by mf2k (Frank Schima)

Owner: changed from sfiera@… to macports-tickets@…

sfiera has retired. See #44785.

comment:6 Changed 7 years ago by ryandesign (Ryan Schmidt)

The developer is now using boost instead of system C++ support, which should work across OS X versions. This was released in version 0.43.1. It fails to build for me, however; I have filed upstream issue 3.

Changed 7 years ago by ryandesign (Ryan Schmidt)

Attachment: bastet-0.43.1.diff added

comment:7 Changed 6 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.