Opened 7 years ago

Last modified 7 years ago

#42064 new enhancement

py-pil @1.1.7_7 Add +tk variant to allow for no-x11 builds

Reported by: danudey (Dan Udey) Owned by: jmroot (Joshua Root)
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: Cc: petrrr
Port: py-pil

Description

Building the Python Image Library via macports draws in py-tkinter, which pulls in quite a few xorg libraries. For systems/users which do not want x11, move tk support to a default variant so that it can be removed at compile time.

Attachments (1)

py-pil+tk.patch (886 bytes) - added by danudey (Dan Udey) 7 years ago.
Patch to move tk support to a variant

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by danudey (Dan Udey)

Attachment: py-pil+tk.patch added

Patch to move tk support to a variant

comment:1 Changed 7 years ago by danudey (Dan Udey)

Cc: danudey@… added
Last edited 7 years ago by danudey (Dan Udey) (previous) (diff)

comment:2 Changed 7 years ago by neverpanic (Clemens Lang)

Cc: danudey@… removed
Owner: changed from macports-tickets@… to jmr@…
Port: py-pil added

You don't need to Cc yourself if you're the reporter. Please Cc the maintainer and set the port field. I've done both of these for you now.

comment:3 Changed 7 years ago by jmroot (Joshua Root)

A variant needs to actually enable or disable functionality; just adding or removing a dependency is not sufficient to accomplish that.

comment:4 Changed 7 years ago by danudey (Dan Udey)

Ah, so removing the dependency removes the installing of tk, but still builds against it if it exists. That's a good point. I'll see if I can figure out how to change that with the package's build system.

comment:5 Changed 7 years ago by jmroot (Joshua Root)

Also, resolving #38844 may be just as good or even better for your purposes.

comment:6 in reply to:  5 Changed 7 years ago by danudey (Dan Udey)

Replying to jmr@…:

Also, resolving #38844 may be just as good or even better for your purposes.

I'll take a look into this as well, thanks!

comment:7 Changed 7 years ago by petrrr

Cc: Peter.Danecek@… added

Cc Me!

comment:8 Changed 7 years ago by petrrr

This ticket is a duplicate of #28462, but maybe it is better to close the old ticket in this case.

Note: See TracTickets for help on using tickets.