ImageMagick @6.8.8-3: build failure of other ports with error: comma at end of enumerator list

[mndavidoff (Monte Davidoff)]

Building pstoedit @3.61_4 fails after I updated to ImageMagick @6.8.8-3_0.

$ port installed ImageMagick
The following ports are currently installed:
  ImageMagick @6.8.8-3_0+graphviz+jbig+jpeg2+rsvg+x11 (active)
$ sudo port -vs install pstoedit
--->  Computing dependencies for pstoedit.
...
libtool: link: ( cd ".libs" && rm -f "libp2edrvlplot.la" && ln -s "../libp2edrvlplot.la" "libp2edrvlplot.la" )
/bin/sh ../libtool --tag=CXX   --mode=compile /usr/bin/g++-4.2 -DHAVE_CONFIG_H -I.  -DHAVE_LIBPLOTTER  -DHAVE_MKSTEMP -DHAVE_MAGIC -fopenmp -DMAGICKCORE_HDRI_ENABLE=0 -DMAGICKCORE_QUANTUM_DEPTH=16 -fopenmp -DMAGICKCORE_HDRI_ENABLE=0 -DMAGICKCORE_QUANTUM_DEPTH=16 -fopenmp -DMAGICKCORE_HDRI_ENABLE=0 -DMAGICKCORE_QUANTUM_DEPTH=16 -I/opt/local/include/ImageMagick-6   -DHAVE_LIBPNG -DDEFAULTGS=/opt/local/bin/gs -DPSTOEDITDATADIR="\"/opt/local/share/pstoedit\"" -DPSTOEDITLIBDIR="\"/opt/local/lib/pstoedit\"" -DBUGGYGPP -pedantic -Wall -Wwrite-strings -Wcast-qual -Wpointer-arith -Wno-long-long  -I/opt/local/include -Wno-long-long -D_LITTLE_ENDIAN  -pipe -Os -arch x86_64 -DINTERNALBOOL -MT drvmagick++.lo -MD -MP -MF .deps/drvmagick++.Tpo -c -o drvmagick++.lo drvmagick++.cpp
libtool: compile:  /usr/bin/g++-4.2 -DHAVE_CONFIG_H -I. -DHAVE_LIBPLOTTER -DHAVE_MKSTEMP -DHAVE_MAGIC -fopenmp -DMAGICKCORE_HDRI_ENABLE=0 -DMAGICKCORE_QUANTUM_DEPTH=16 -fopenmp -DMAGICKCORE_HDRI_ENABLE=0 -DMAGICKCORE_QUANTUM_DEPTH=16 -fopenmp -DMAGICKCORE_HDRI_ENABLE=0 -DMAGICKCORE_QUANTUM_DEPTH=16 -I/opt/local/include/ImageMagick-6 -DHAVE_LIBPNG -DDEFAULTGS=/opt/local/bin/gs -DPSTOEDITDATADIR=\"/opt/local/share/pstoedit\" -DPSTOEDITLIBDIR=\"/opt/local/lib/pstoedit\" -DBUGGYGPP -pedantic -Wall -Wwrite-strings -Wcast-qual -Wpointer-arith -Wno-long-long -I/opt/local/include -Wno-long-long -D_LITTLE_ENDIAN -pipe -Os -arch x86_64 -DINTERNALBOOL -MT drvmagick++.lo -MD -MP -MF .deps/drvmagick++.Tpo -c drvmagick++.cpp  -fno-common -DPIC -o .libs/drvmagick++.o
In file included from /opt/local/include/ImageMagick-6/magick/MagickCore.h:88,
                 from /opt/local/include/ImageMagick-6/Magick++/Include.h:41,
                 from /opt/local/include/ImageMagick-6/Magick++.h:9,
                 from drvmagick++.h:35,
                 from drvmagick++.cpp:31:
/opt/local/include/ImageMagick-6/magick/compare.h:40: error: comma at end of enumerator list
make[2]: *** [drvmagick++.lo] Error 1
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_pstoedit/pstoedit/work/pstoedit-3.61/src'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_pstoedit/pstoedit/work/pstoedit-3.61/src'
make: *** [all-recursive] Error 1
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_pstoedit/pstoedit/work/pstoedit-3.61'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_pstoedit/pstoedit/work/pstoedit-3.61" && /usr/bin/make -w all 
Exit code: 2
Error: org.macports.build for port pstoedit returned: command execution failed
Warning: targets not executed for pstoedit: org.macports.activate org.macports.build org.macports.destroot org.macports.install
Please see the log file for port pstoedit for details:
    /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_pstoedit/pstoedit/main.log
To report a bug, follow the instructions in the guide:
    http://guide.macports.org/#project.tickets
Error: Processing of port pstoedit failed

[ryandesign (Ryan Carsten Schmidt)]

The ImageMagick developers have made this mistake before: #16072. I'll fix it again.

This problem only seems to affect older compilers like the Apple gcc 4.2 you're using on Snow Leopard. There's no problem with clang 5 on Mavericks.

[ryandesign (Ryan Carsten Schmidt)]

Fixed in r116575. Still needs to be reported to the developers.

[mndavidoff (Monte Davidoff)]

Thank you for the prompt fix -- bugs like this are another reason for me to upgrade to Mavericks, which I plan to do real soon now. :-)

[ryandesign (Ryan Carsten Schmidt)]

Well, on Mavericks you'll just have problems of a different sort :)

[jmroot (Joshua Root)]

Replying to ryandesign@…:

This problem only seems to affect older compilers like the Apple gcc 4.2 you're using on Snow Leopard. There's no problem with clang 5 on Mavericks.

It's a difference in C standards, not really a compiler difference. Clang happens to default to C99 and gcc-4.2 defaults to C89. The trailing comma was prohibited in C89 but is optional in C99. Presumably clang -std=c89 would generate an error on this code and gcc-4.2 -std=c99 would not.