Opened 8 years ago

Closed 8 years ago

#42476 closed enhancement (fixed)

py-mock @1.0.1: enable py33 and py34 as well

Reported by: petrrr Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: patrik.hartlen@…
Port: py-mock

Description

Please consider enabling the above subports as well.

I am aware of the fact that from Python 3.3 on mock is available as part of the standard library as unittest.mock. So there is probably some reasoning behind the fact that mentioned subports are NOT enables. They are redundant.

However, some packages to not yet handle the difference in the namespace. So have these ports around for some while would be useful to keep test working correctly.

Change History (7)

comment:1 Changed 8 years ago by petrrr

Update:

I have now no *immediate* need that this is implemented. I was able resolve the problem with mock in python 3.3 in the respective packages I was interested in, so this concrete use case is gone.

Still, I could imagine there are cases where py33-mock and py34-mock might be helpful to get software working fast. So consider this and close if found appropriate.

I a fine if this ticket is just closed.

comment:2 in reply to:  1 Changed 8 years ago by patrik.hartlen@…

Replying to Peter.Danecek@…:

Update:

I have now no *immediate* need that this is implemented. I was able resolve the problem with mock in python 3.3 in the respective packages I was interested in, so this concrete use case is gone.

Still, I could imagine there are cases where py33-mock and py34-mock might be helpful to get software working fast. So consider this and close if found appropriate.

I a fine if this ticket is just closed.

I was trying to find how similar modules have been handled on macports, looking at argparse that was introduced in 2.7 and 3.2 that module is not included in the Portfile for the versions 2.7 and 3.2. I will try to find other examples before closing the ticket.

comment:3 Changed 8 years ago by neverpanic (Clemens Lang)

I think other instances of the same situation don't install the duplicate ports – e.g. py-distutils-extra doesn't exist for 2.7.

comment:4 Changed 8 years ago by petrrr

Not sure if the example of argparse applies here, because of the difference in namespace. The package provides mock while Python 3.3+ provides unitest.mock. Software needs to account for this difference, so it may compare more to the situation with simplejson (package) vs. json (Python 2.6+) where py-simplejson packages still exist or maybe the cited py-distutils-extra, which I cannot say much about.

But as I mentioned before, this is only an extra consideration. For my special purpose it is not relevant anymore and the ticket can just be closed. Not implementing this, might be the extra incentive to changes depending software sooner ;-)

comment:5 Changed 8 years ago by petrrr

Implementing this ticket would solve #42811.

comment:6 in reply to:  5 Changed 8 years ago by patrik.hartlen@…

Replying to Peter.Danecek@…:

Implementing this ticket would solve #42811.

Ok I see no harm in adding support for Python 3.3 & 3.4 since it will fix upstream dependencies in other ports waiting for patches. I don't know if this will violate any rules so if it is ok with macport devs then lets add a patch for 3.3 and 3.4.

comment:7 Changed 8 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.