Opened 5 years ago

Closed 5 years ago

#42520 closed defect (fixed)

libquvi-scripts: libquvi-scripts/0.9/common/quvi/youtube.lua requires 'socket.url', missing lua dependencies.

Reported by: dbevans (David B. Evans) Owned by: nerdling (Jeremy L)
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: haspatch Cc: cooljeanius (Eric Gallager)
Port: libquvi-scripts

Description (last modified by dbevans (David B. Evans))

When I run totem I get the following critical warning:

** (totem-pl-parser-videosite:39219): CRITICAL **: [_chk_script_ident] .../local/share/libquvi-scripts/0.9/common/quvi/youtube.lua:109: module 'socket.url' not found:
	no field package.preload['socket.url']
	no file '/opt/local/share/lua/5.2/socket/url.lua'
	no file '/opt/local/share/lua/5.2/socket/url/init.lua'
	no file '/opt/local/lib/lua/5.2/socket/url.lua'
	no file '/opt/local/lib/lua/5.2/socket/url/init.lua'
	no file './socket/url.lua'
	no file '/opt/local/share/libquvi-scripts/0.9/common/socket/url.lua'
	no file '/opt/local/lib/lua/5.2/socket/url.so'
	no file '/opt/local/lib/lua/5.2/loadall.so'
	no file './socket/url.so'
	no file '/opt/local/lib/lua/5.2/socket.so'
	no file '/opt/local/lib/lua/5.2/loadall.so'
	no file './socket.so'

Looking at /opt/local/share/libquvi-scripts/0.9/common/quvi/youtube.lua:109

function M.normalize(url)
  if not url then
    return url
  end

  local U = require 'socket.url'

Attachments (1)

patch-libquivi-scripts.diff (11.6 KB) - added by dbevans (David B. Evans) 5 years ago.
Proposed patch for review

Download all attachments as: .zip

Change History (10)

comment:1 Changed 5 years ago by dbevans (David B. Evans)

Description: modified (diff)

comment:2 Changed 5 years ago by dbevans (David B. Evans)

Description: modified (diff)
Summary: libquvi-scripts: scripts installed in wrong directorylibquvi-scripts: libquvi-scripts/0.9/common/quvi/youtube.lua requires 'socket.url'

comment:3 Changed 5 years ago by dbevans (David B. Evans)

After looking into this further, this appears to be due to missing dependencies.

socket.url is provided by 3rd party lua package luasocket (MacPorts lua-luasocket). The libquvi-scripts README file confirms this dependency as well as several others.

Requirements
------------

* Lua BitOp 1.0.1
  http://bitop.luajit.org/
    $ sudo aptitude install lua-bitop

* LuaExpat 1.2.0
  http://matthewwild.co.uk/projects/luaexpat/
    $ sudo aptitude install lua-expat

* LuaJSON 1.1.1
  http://www.eharning.us/wiki/luajson/
    $ sudo aptitude install lua-json

* LuaSocket 2.0.2
  http://w3.impa.br/~diego/software/luasocket/
    $ sudo aptitude install lua-socket

Unfortunately, the lua-luasocket port is broken as the current version only supports lua 5.1 and we're at lua 5.2.2 now (#35858).

Attached for review is an admittedly hackish work-around that fixes the problem reported here by taking the url.lua script from lua-luasocket and manually installing it into the libquvi-scripts common script directory. Grepping of the code shows that this is the only script required from lua-luasocket and the patch fixes totem's immediate problem, but there are undoubtedly other similar problems related to the other 3rd party packages -- I just haven't run in to them yet.

Last edited 5 years ago by dbevans (David B. Evans) (previous) (diff)

Changed 5 years ago by dbevans (David B. Evans)

Attachment: patch-libquivi-scripts.diff added

Proposed patch for review

comment:4 Changed 5 years ago by dbevans (David B. Evans)

Keywords: haspatch added

comment:5 Changed 5 years ago by dbevans (David B. Evans)

Summary: libquvi-scripts: libquvi-scripts/0.9/common/quvi/youtube.lua requires 'socket.url'libquvi-scripts: libquvi-scripts/0.9/common/quvi/youtube.lua requires 'socket.url', missing lua dependencies.

comment:6 Changed 5 years ago by dbevans (David B. Evans)

Status of missing dependencies:

Last edited 5 years ago by dbevans (David B. Evans) (previous) (diff)

comment:7 Changed 5 years ago by nerdling (Jeremy L)

lua-luasocket updated in r119354.

lua-luajson added in r119358.

Last edited 5 years ago by nerdling (Jeremy L) (previous) (diff)

comment:8 Changed 5 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:9 Changed 5 years ago by nerdling (Jeremy L)

Resolution: fixed
Status: newclosed

Now that all the packages are available, added dependencies and revbumped in r119363.

Note: See TracTickets for help on using tickets.