Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#42545 closed update (fixed)

xraylib: update to version 3.0.0

Reported by: Tom.Schoonjans@… Owned by: larryv (Lawrence Velázquez)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc:
Port: xraylib

Description

Version bump.

Also added support for multiple perl versions and ruby versions

Attachments (2)

Portfile (7.7 KB) - added by Tom.Schoonjans@… 7 years ago.
diff for xraylib 3.0.0
Portfile.diff (5.0 KB) - added by Tom.Schoonjans@… 7 years ago.
Portfile diff

Download all attachments as: .zip

Change History (14)

Changed 7 years ago by Tom.Schoonjans@…

Attachment: Portfile added

diff for xraylib 3.0.0

comment:1 Changed 7 years ago by mf2k (Frank Schima)

Per the guidelines, please instead attach a unified diff of the Portfile.

comment:2 Changed 7 years ago by Tom.Schoonjans@…

sorry uploaded wrong file initially

comment:3 Changed 7 years ago by ryandesign (Ryan Schmidt)

This diff undoes several changes that were made to the port months ago already; we don't want to undo those changes.

Changed 7 years ago by Tom.Schoonjans@…

Attachment: Portfile.diff added

Portfile diff

comment:4 Changed 7 years ago by Tom.Schoonjans@…

sorry about that: looks like I was using the wrong version of the Portfile initially

comment:5 Changed 7 years ago by Tom.Schoonjans@…

I am wondering if this change that was introduced a couple of months ago is actually appropriate.

It was (for the gcc47 variant):

depends_lib-append port:gcc47

and now is:

depends_lib-append path:lib/libgcc/libgcc_s.1.dylib:libgcc
depends_build-append port:gcc47

However, this looks pretty dangerous to me since this option impacts which Fortran compiler is selected. If one looks at the output of otool, it becomes quite clear that the library is linked to some libraries (libgfortran, libquadmath) that are provided by the complete gcc47 package:

/opt/local/lib/libxrlf03.7.dylib (compatibility version 8.0.0, current version 8.0.0)
/opt/local/lib/libxrl.7.dylib (compatibility version 8.0.0, current version 8.0.0)
/opt/local/lib/libgcc/libgfortran.3.dylib (compatibility version 4.0.0, current version 4.0.0)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 169.3.0)
/opt/local/lib/libgcc/libgcc_s.1.dylib (compatibility version 1.0.0, current version 1.0.0)
/opt/local/lib/libgcc/libquadmath.0.dylib (compatibility version 1.0.0, current version 1.0.0)

I am pretty sure that because of this gcc47 needs to remain depends_lib.

Any thoughts?

comment:6 in reply to:  5 Changed 7 years ago by larryv (Lawrence Velázquez)

Those libraries are provided by libgcc (and libgcc-devel).

% port contents libgcc
Port libgcc contains:
  /opt/local/lib/libgcc/libasan.0.dylib
  /opt/local/lib/libgcc/libatomic.1.dylib
  /opt/local/lib/libgcc/libgcc_ext.10.4.dylib
  /opt/local/lib/libgcc/libgcc_ext.10.5.dylib
  /opt/local/lib/libgcc/libgcc_s.1.dylib
  /opt/local/lib/libgcc/libgfortran.3.dylib
  /opt/local/lib/libgcc/libgomp.1.dylib
  /opt/local/lib/libgcc/libitm.1.dylib
  /opt/local/lib/libgcc/libobjc-gnu.4.dylib
  /opt/local/lib/libgcc/libquadmath.0.dylib
  /opt/local/lib/libgcc/libssp.0.dylib
  /opt/local/lib/libgcc/libstdc++.6.dylib
  /opt/local/lib/libstdc++.6.dylib
%

comment:7 Changed 7 years ago by Tom.Schoonjans@…

Cool, I didn't know about that!

By the way, I uploaded the correct version of the Portfile.diff.

comment:8 Changed 7 years ago by Tom.Schoonjans@…

Any reason why this is taking so long?

My Mac users are waiting for this…

Thanks

comment:9 Changed 7 years ago by larryv (Lawrence Velázquez)

Keywords: haspatch maintainer added
Owner: changed from macports-tickets@… to larryv@…
Status: newassigned

Just fell through the cracks, I expect. Next time, try pinging macports-dev to try getting a committer’s attention.

comment:10 Changed 7 years ago by Tom.Schoonjans@…

Thanks, I'll keep it mind… I have some other tickets that have been open for months...

comment:11 Changed 7 years ago by larryv (Lawrence Velázquez)

Resolution: fixed
Status: assignedclosed
Version: 2.2.1

Sorry, I committed this 5 days ago. r117556

comment:12 Changed 7 years ago by Tom.Schoonjans@…

Thanks!

Would you mind having a look at my two other submissions #38755 and #39255?

Cheers,

Tom

Note: See TracTickets for help on using tickets.