Opened 10 years ago
Closed 10 years ago
#42647 closed update (fixed)
Update libupnp to 1.6.19
| Reported by: | ctreleaven (Craig Treleaven) | Owned by: | ctreleaven (Craig Treleaven) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | |
| Port: | libupnp |
Description
Attached patch updates the libupnp port to 1.6.19 (existing version was ~6 years old) to pick up an extensive list of changes, including security patches.
Builds successfully on 10.6.8/XCode 3.2.6 and 10.9.2/XCode 5.mumble. However, VLC still does not see my primary UPNP source (MythTV). Only other dependent is uShare which is, I think, pretty much defunct.
Attachments (1)
Change History (11)
Changed 10 years ago by ctreleaven (Craig Treleaven)
| Attachment: | patch-libupnp-1.6.19_2014Feb28_01.diff added |
|---|
comment:1 Changed 10 years ago by ctreleaven (Craig Treleaven)
comment:2 Changed 10 years ago by larryv (Lawrence Velázquez)
| Cc: | sfiera@… removed |
|---|---|
| Owner: | changed from macports-tickets@… to sfiera@… |
| Type: | defect → update |
comment:4 Changed 10 years ago by ctreleaven (Craig Treleaven)
Port appears to be abandoned. Could another comitter please review?
comment:5 Changed 10 years ago by mf2k (Frank Schima)
| Owner: | changed from sfiera@… to ctreleaven@… |
|---|---|
| Version: | 2.2.1 |
sfiera has retired. See #44785.
Craig, go ahead and commit.
comment:6 Changed 10 years ago by ctreleaven (Craig Treleaven)
There are bugs in 1.6.19 which constitute a security issue, see:
https://sourceforge.net/p/pupnp/bugs/122/
At least one distribution (Mageia) has applied patches as a critical security fix:
https://bugs.mageia.org/show_bug.cgi?id=14143
Upstream has accepted the fixes but doesn't seem to be moving towards a new release. I'll test applying these as patches to our port.
comment:7 Changed 10 years ago by ctreleaven (Craig Treleaven)
Tested with VLC and uShare under OS X 10.6.8.
uShare requires fixes which I'll commit if the buildbots like my changes.
Note that (rebuilt) VLC now lists available UPnP servers which is a step forward! Console shows VLC throwing a bunch of warnings/errors while accessing uShare. I believe this is more of a problem with uShare than VLC but I'll try to look into this more. Again, I'll rev-bump VLC and VLC-devel if the libupnp change doesn't error on the buildbots.
Committed in r126547
comment:10 Changed 10 years ago by ctreleaven (Craig Treleaven)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Sorry, the Type field should have been set to "Update" but I can't fix it now.