VLC-devel: build fails when port FreeRDP is active

[dbevans (David B. Evans)]

Build fails as follows:

libtool: compile:  /usr/bin/clang -DHAVE_CONFIG_H -I. -I.. -DMODULE_STRING=\"qtcapture\" -D__PLUGIN__ -I./access -I./codec -I../include -I../include -I/opt/local/include -D__unix__=1 -I/opt/local/var/macports/build/_opt_macports_trunk_dports_multimedia_VLC-devel/VLC-devel/work/VLC-devel-2.1.99/contrib/include -pipe -Os -arch x86_64 -D_INTL_REDIRECT_MACROS -std=gnu99 -I/opt/local/var/macports/build/_opt_macports_trunk_dports_multimedia_VLC-devel/VLC-devel/work/VLC-devel-2.1.99/contrib/include -fvisibility=hidden -ffast-math -funroll-loops -fomit-frame-pointer -MT access/qtcapture.lo -MD -MP -MF access/.deps/qtcapture.Tpo -c access/qtcapture.m  -fno-common -DPIC -o access/.libs/qtcapture.o
../doltlibtool  --tag=CC   --mode=compile /usr/bin/clang -DHAVE_CONFIG_H -I. -I..  -DMODULE_STRING=\"$(p="access/librdp_plugin_la-rdp.lo"; p="${p##*/}"; p="${p#lib}"; p="${p%_plugin*}"; p="${p%.lo}"; echo "$p")\" -D__PLUGIN__  -I./access -I./codec -I../include -I../include -I/opt/local/include -D__unix__=1 -I/opt/local/var/macports/build/_opt_macports_trunk_dports_multimedia_VLC-devel/VLC-devel/work/VLC-devel-2.1.99/contrib/include   -pipe -Os -arch x86_64 -D_INTL_REDIRECT_MACROS -I/opt/local/var/macports/build/_opt_macports_trunk_dports_multimedia_VLC-devel/VLC-devel/work/VLC-devel-2.1.99/contrib/include -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -Werror-implicit-function-declaration -pipe -fvisibility=hidden -ffast-math -funroll-loops -fomit-frame-pointer -MT access/librdp_plugin_la-rdp.lo -MD -MP -MF access/.deps/librdp_plugin_la-rdp.Tpo -c -o access/librdp_plugin_la-rdp.lo `test -f 'access/rdp.c' || echo './'`access/rdp.c
In file included from access/rdp.c:39:
In file included from /opt/local/include/freerdp/freerdp.h:39:
In file included from /opt/local/include/freerdp/types.h:64:
In file included from /opt/local/include/winpr/collections.h:31:
In file included from /opt/local/include/winpr/stream.h:26:
In file included from /opt/local/include/winpr/endian.h:25:
/opt/local/include/winpr/platform.h:167:19: warning: 'TARGET_OS_IPHONE' is not defined, evaluates to 0 [-Wundef]
#if (__APPLE__ && TARGET_OS_IPHONE)
                  ^
access/rdp.c:201:27: error: no member named 'sw_gdi' in 'struct rdp_settings'
    p_instance->settings->sw_gdi = true; /* render in buffer */
    ~~~~~~~~~~~~~~~~~~~~  ^
access/rdp.c:202:27: error: no member named 'fullscreen' in 'struct rdp_settings'; did you mean 'Fullscreen'?
    p_instance->settings->fullscreen = true;
                          ^~~~~~~~~~
                          Fullscreen
/opt/local/include/freerdp/settings.h:968:15: note: 'Fullscreen' declared here
        ALIGN64 BOOL Fullscreen; /* 1537 */
                     ^
access/rdp.c:203:27: error: no member named 'hostname' in 'struct rdp_settings'
    p_instance->settings->hostname = strdup( p_sys->psz_hostname );
    ~~~~~~~~~~~~~~~~~~~~  ^
access/rdp.c:204:27: error: no member named 'username' in 'struct rdp_settings'; did you mean 'Username'?
    p_instance->settings->username =
                          ^~~~~~~~
                          Username
/opt/local/include/freerdp/settings.h:759:16: note: 'Username' declared here
        ALIGN64 char* Username; /* 21 */
                      ^
access/rdp.c:206:27: error: no member named 'password' in 'struct rdp_settings'; did you mean 'Password'?
    p_instance->settings->password =
                          ^~~~~~~~
                          Password
/opt/local/include/freerdp/settings.h:760:16: note: 'Password' declared here
        ALIGN64 char* Password; /* 22 */
                      ^
access/rdp.c:208:27: error: no member named 'port' in 'struct rdp_settings'
    p_instance->settings->port = p_sys->i_port;
    ~~~~~~~~~~~~~~~~~~~~  ^
access/rdp.c:209:27: error: no member named 'encryption' in 'struct rdp_settings'
    p_instance->settings->encryption =
    ~~~~~~~~~~~~~~~~~~~~  ^
access/rdp.c:220:36: error: no member named 'width' in 'struct rdp_settings'
             p_instance->settings->width,
             ~~~~~~~~~~~~~~~~~~~~  ^

...

See attached log files.

[dbevans (David B. Evans)]

Build log showing failure

[jeremyhu (Jeremy Huddleston Sequoia)]

Looks like a freerdp bug to me. There's not much VLC-devel can do to workaround buggy headers in other ports (other than to disable that functionality).

It looks like VLC-devel *tried* to disable the functionality bug failed:

# Input Plugins
# build fails when FreeRDP is installed
# build fails when opencv is installed
configure.args-append \
    --enable-dvdnav --enable-dvdread --disable-smbclient --disable-vcdx \
    --disable-macosx-qtkit --disable-macosx-eyetv --disable-realrtsp \
    --disable-libfreerdp --disable-opencv \
    --enable-sftp

[jeremyhu (Jeremy Huddleston Sequoia)]

VLC-devel adjusted in r117521, but the real bug in freerdp should be fixed.

[jeremyhu (Jeremy Huddleston Sequoia)]

r117522 fixes the missing include in FreeRDP

It looks like the VLC issue is discussed by FreeBSD at:

​http://www.freebsd.org/cgi/query-pr.cgi?pr=185848&cat=

[jeremyhu (Jeremy Huddleston Sequoia)]

Additional FreeRDP fixes in r117523.

VLC-devel updated to use it in r117524.