Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#42711 closed defect (fixed)

libfdk-aac @0.1.3_0 does not build under 10.5.8 PPC

Reported by: udbraumann Owned by: mopihopi
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: dbevans (David B. Evans), ryandesign (Ryan Schmidt)
Port: libfdk-aac

Description

since FDK_HIGH_PERFORMANCE remains undefined, build process stops in ./libFDK/include/FDK_archdef.h

Attachments (2)

main.log (15.6 KB) - added by udbraumann 7 years ago.
libfdk-aac.ppc.patch (535 bytes) - added by mopihopi 7 years ago.

Download all attachments as: .zip

Change History (10)

Changed 7 years ago by udbraumann

Attachment: main.log added

comment:1 Changed 7 years ago by dbevans (David B. Evans)

Owner: changed from macports-tickets@… to mopihopi@…
Port: libfdk-aac added; ffmpeg removed
Version: 2.2.1

Please CC maintainer when submitting tickets

port info --maintainer libfdk-aac
maintainer: mopihopi@osj.us, openmaintainer@macports.org

and set Port field to the name of the port that failed, not necessarily the one that you were intending to build.

comment:2 in reply to:  1 Changed 7 years ago by t.tensi@…

Dear all,

I have also been bitten by that (being on PPC Tiger).

./libFDK/include/FDK_archdef.h looks for a preprocessor symbol __powerpc__ that does not seem to be set. Once this symbol is defined, the build is successful.

Best regards,

Thomas

Changed 7 years ago by mopihopi

Attachment: libfdk-aac.ppc.patch added

comment:3 Changed 7 years ago by neverpanic (Clemens Lang)

Keywords: haspatch added

comment:4 Changed 7 years ago by dbevans (David B. Evans)

If the reporter can confirm that the attached patch fixes the problem, I'll commit it.

comment:5 Changed 7 years ago by danielluke (Daniel J. Luke)

I can confirm that this patch fixes the build on 10.5.8/ppc.

comment:6 in reply to:  5 Changed 7 years ago by dbevans (David B. Evans)

Resolution: fixed
Status: newclosed

Replying to dluke@…:

I can confirm that this patch fixes the build on 10.5.8/ppc.

Thanks. Patch committed in r117638.

comment:7 Changed 7 years ago by ryandesign (Ryan Schmidt)

Cc: devans@… ryandesign@… added

This will only work correctly if the universal variant is not selected. If different flags need to be passed with different architectures, the universal variant should be fixed by using the muniversal portgroup.

comment:8 Changed 7 years ago by dbevans (David B. Evans)

Update submitted in #42881 which fixes the +universal issue without the need for flag manipulation or muniversal.

Note: See TracTickets for help on using tickets.