Opened 7 years ago

Closed 4 years ago

#42767 closed defect (worksforme)

Commit email shows property changes incorrectly

Reported by: ryandesign (Ryan Schmidt) Owned by: admin@…
Priority: Normal Milestone:
Component: server/hosting Version:
Keywords: Cc:
Port:

Description

r117622 changed the svn:ignore property of the directory trunk/base/src/macports1.0 as follows:

Index: trunk/base/src/macports1.0
===================================================================
--- trunk/base/src/macports1.0	(revision 117621)
+++ trunk/base/src/macports1.0	(revision 117622)

Property changes on: trunk/base/src/macports1.0
___________________________________________________________________
Modified: svn:ignore
## -1,5 +1,6 ##
 *.dylib
+Makefile
 macports_autoconf.tcl
+macports_fastload.tcl
 macports_test_autoconf.tcl
-macports_fastload.tcl
 pkgIndex.tcl

This is how svn diff shows it. Trac shows it similarly. In the commit email, however, it's shown less well. The text part of the email shows it like this:

Property changes on: trunk/base/src/macports1.0
___________________________________________________________________
Modified: svn:ignore
   - *.dylib
macports_autoconf.tcl
macports_test_autoconf.tcl
macports_fastload.tcl
pkgIndex.tcl

   + *.dylib
Makefile
macports_autoconf.tcl
macports_fastload.tcl
macports_test_autoconf.tcl
pkgIndex.tcl

This is unnecessarily convoluted but is at least accurate. The HTML part, however, which is what most viewers will see in their email readers, is completely wrong:

<div id=3D"patch">
<h3>Diff</h3>
<a id=3D"trunkbasesrcmacports10"></a>
<div class=3D"propset"><h4>Property changes: trunk/base/src/macports1.0</=
h4>
<pre class=3D"diff"><span>
</span></pre></div>
<a id=3D"svnignore"></a>
<div class=3D"modfile"><h4>Modified: svn:ignore</h4></div>
<span class=3D"cx">macports_autoconf.tcl
</span><span class=3D"cx">macports_test_autoconf.tcl
</span><span class=3D"cx">macports_fastload.tcl
</span><span class=3D"cx">pkgIndex.tcl
</span><span class=3D"cx">   + *.dylib
</span><span class=3D"cx">Makefile
</span><span class=3D"cx">macports_autoconf.tcl
</span><span class=3D"cx">macports_fastload.tcl
</span><span class=3D"cx">macports_test_autoconf.tcl
</span><span class=3D"cx">pkgIndex.tcl
</span>

Note how it's an encoding of the text version, but with the first line (" - *.dylib") omitted, thereby making it unintelligible.

Is Mac OS Forge doing this deliberately, or is this just the behavior of the SVN::Notify script we're using to send emails? If the latter, are we using the latest version of SVN::Notify, 2.84? If not, could we update to that version to see if that helps?

Change History (3)

comment:1 Changed 6 years ago by jmroot (Joshua Root)

Owner: changed from wsiegrist@… to admin@…

comment:2 Changed 4 years ago by ryandesign (Ryan Schmidt)

Owner: changed from admin@… to admin@…
Status: newassigned

comment:3 Changed 4 years ago by raimue (Rainer Müller)

Resolution: worksforme
Status: assignedclosed

With the move to Git this should be obsolete.

Note: See TracTickets for help on using tickets.