Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#42901 closed request (fixed)

lua51 port for Lua 5.1.5

Reported by: hadrielk@… Owned by: anddam (Andrea D'Amore)
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: Cc: ryandesign (Ryan Schmidt), alexeiz@…, mojca (Mojca Miklavec), cooljeanius (Eric Gallager)
Port: lua51

Description

Macports changed the lua port to be Lua 5.2.x based, but there are non-trivial differences between Lua 5.2 and the previous 5.1, as discussed in tickets #40421 and #40423.

Right now there's lua@5.2.1 and lua50@5.0.3, so a 'lua51' port (@5.1.5) would be great. (I would provide a patch but I have no idea how macports does its magic - I just love using it :)

If this is done perhaps the other two tickets can be closed and told to install lua51.

Change History (10)

comment:1 Changed 7 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added
Port: lua51 added; lua removed
Type: enhancementrequest

Yes, we should add a lua51 port, and rename the lua port to lua52, however we also need to make all three ports simultaneously installable. Currently lua50 and lua conflict with one another. Making them simultaneously installable will mean we'll have to change were the files get installed, which will mean needing to update every port that uses lua to know about the new file locations.

comment:2 Changed 7 years ago by hadrielk@…

That sounds like a lot more work - is it? If it is, then I think for now a restriction that you can only install (or only activate) one or the other is ok - at least it lets folks get 5.1 installed.

Personally I have to use both, at various times, but I'm probably not a normal case; and I'm fine with de-activating/re-activating or removing/installing each time, if that's the price to pay for being able to do it at all.

It's not optimal, obviously, but not too crazy either I think, to get something sooner. :)

comment:3 Changed 7 years ago by ryandesign (Ryan Schmidt)

Yes, it's a lot more work. But it is MacPorts convention that when ports are named fooXY, fooXY, etc., where XY and XZ are number, then the ports shall be simultaneously installable. The lua50 port already breaks this convention and I want to fix that error, not perpetuate it.

I am currently working on updating the lua port to 5.2.3 (#42892) and in the process discovering what a mess the build system is... After I get a basic update to 5.2.3 done, I'll see what a reasonable renaming or relocating of the files might look like.

comment:4 Changed 7 years ago by alexeiz@…

Cc: alexeiz@… added

Cc Me!

comment:5 Changed 7 years ago by mojca (Mojca Miklavec)

Cc: mojca@… added

Cc Me!

comment:6 Changed 7 years ago by anddam (Andrea D'Amore)

Owner: changed from macports-tickets@… to and.damore@…

comment:7 Changed 7 years ago by anddam (Andrea D'Amore)

Resolution: fixed
Status: newclosed

New lua51 port added in r118448.

This is rewritten over latest 5.1 portfile, this is a versioned port and doesn't conflicts with either lua and lua50. The latter should follow the same lead so all version could be used at the same time.

Please test it and report any issue you find, I was able to run the whole test directory in $prefix/share/example .

Ticket closed.

comment:8 Changed 7 years ago by mojca (Mojca Miklavec)

Thank you. Does luajit now link against Lua 5.2 or 5.1? I need to put "test CMake's FindLua51" on my TODO list now.

comment:9 Changed 7 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:10 in reply to:  8 Changed 7 years ago by anddam (Andrea D'Amore)

Replying to mojca@…:

Thank you. Does luajit now link against Lua 5.2 or 5.1? I need to put "test CMake's FindLua51" on my TODO list now.

That luajit port fiddling with installed lua port was my mistake. I recently updated the port and cleaned it up, luajit ships its own 5.1 lua and is only partially ABI compatible with 5.2, I've enabled the partial compatibility by default as well, see #41132.

To be more clear: luajit doesn't need linking to lua port at all and doesn't depend on it.

Last edited 7 years ago by anddam (Andrea D'Amore) (previous) (diff)
Note: See TracTickets for help on using tickets.