Opened 7 years ago

Closed 7 years ago

#42902 closed submission (fixed)

libmediaart @0.3.0 new Portfile

Reported by: juanrgar (Juan R. García Blanco) Owned by: dbevans (David B. Evans)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: devans
Port: libmediaart

Description

I don't know if these variants make sense. Also, I don't know if I should add a dependency on gtk-doc to build documentation.

Attachments (2)

Portfile (1.7 KB) - added by juanrgar (Juan R. García Blanco) 7 years ago.
Portfile.2 (1.8 KB) - added by juanrgar (Juan R. García Blanco) 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by juanrgar (Juan R. García Blanco)

Attachment: Portfile added

comment:1 Changed 7 years ago by dbevans (David B. Evans)

Owner: changed from macports-tickets@… to devans@…
Status: newassigned

comment:2 Changed 7 years ago by dbevans (David B. Evans)

My two cents is to drop the gdkpixbuf variant and just enable gdk-pixbuf support as it is part and parcel of gtk+ and this is meant to be primarily a GNOME port. gdk-pixbuf also supports +quartz so you might see if a +quartz variant makes sense. Leave +qt as a variant, this would allow use with KDE or the like.

I'll give it a try and let you know about dependency issues if any.

comment:3 Changed 7 years ago by dbevans (David B. Evans)

After testing, I think you had the right idea in the first place. You need to be able to deactivate gdk-pixbuf support if you select qt support as you have to choose one or the other. Because of this, you should mark each of the variants as conflicting with each other and only set +gdkpixbuf as the default variant if +qt is not set. You also might think about renaming +qt to +qt4 since we have both qt3-mac and qt4-mac ports and qt5 is available (although not ported to MacPorts yet).

With respect to gtk-doc, it is only necessary when you want to re-generate the gtk-doc documentation after say the documentation headers in the code have changed. This is an upstream issue as in generating a new tarball version. The tarball comes with the pre-generated docs included and they are installed without gtk-doc coming into play. So no need to depend on gtk-doc.

One final little nit. By GNOME standards 0.3.0 is an unstable version number (minor version is odd) so for livecheck to work correctly you need to use

livecheck.type gnome-with-unstable

Last edited 7 years ago by dbevans (David B. Evans) (previous) (diff)

Changed 7 years ago by juanrgar (Juan R. García Blanco)

Attachment: Portfile.2 added

comment:4 Changed 7 years ago by juanrgar (Juan R. García Blanco)

This new Portfile addresses some of the issues you pointed out:

  • +qt becomes +qt4. Right now I don't feel the need to include a +qt3 variant, although it could be a good idea (I take this action).
  • livecheck.type changed to gnome-with-unstable
  • +gdkpixbuf is only default if +qt4 is not set. I don't know if that IF is the right way to achieve that though. I've checked that it works.
  • I haven't added a +quartz variant since gdk-pixbuf2 does not seem to provide it neither. I may be missing something here.

Looking forward to read your feedback :)

comment:5 Changed 7 years ago by dbevans (David B. Evans)

Resolution: fixed
Status: assignedclosed

Looks good to me as is. Committed in r118001. Thanks.

Note: See TracTickets for help on using tickets.