Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#42938 closed defect (fixed)

BUG: mysql56 fails to build universal on Mavericks

Reported by: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez) Owned by: pixilla (Bradley Giesbrecht)
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: haspatch mavericks Cc:
Port: mysql56

Description

r114637 fixed #40865, but I think it may have fixed it twice.
I believe this code is unnecessary

    if {[string match *clang* ${configure.cxx}] &&
              ${os.major} >= 13} {

        configure.args-append \
                        -DCMAKE_CXX_FLAGS:STRING="-stdlib=libstdc++"
    }

since upgrading to 5.6.15 (https://dev.mysql.com/doc/relnotes/mysql/5.6/en/news-5-6-15.html) was sufficient.

I do not know if there is any other reason to use libstdc++, but setting CMAKE_CXX_FLAGS breaks the universal build because cmake then ignores CXXFLAGS, which is is where -arch is set.

If libstdc++ is still needed, may I suggest that the following would allow the universal build to continue to work.

    if {[string match *clang* ${configure.cxx}] &&
              ${os.major} >= 13} {

        configure.cxxflags-append \
                        -stdlib=libstdc++
    }

I have attached both possible fixes.

Attachments (2)

Portfile.1.diff (826 bytes) - added by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez) 7 years ago.
Portfile.2.diff (723 bytes) - added by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez) 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Attachment: Portfile.1.diff added

Changed 7 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Attachment: Portfile.2.diff added

comment:1 Changed 7 years ago by mf2k (Frank Schima)

Cc: pixilla@… removed
Owner: changed from macports-tickets@… to pixilla@…

comment:2 Changed 7 years ago by pixilla (Bradley Giesbrecht)

Last edited 7 years ago by pixilla (Bradley Giesbrecht) (previous) (diff)

comment:3 Changed 7 years ago by pixilla (Bradley Giesbrecht)

Resolution: fixed
Status: newclosed

See r118041

Thanks mcalhoun.

Last edited 7 years ago by pixilla (Bradley Giesbrecht) (previous) (diff)
Note: See TracTickets for help on using tickets.