Opened 7 years ago

Last modified 7 years ago

#43024 new submission

[NEW] p5-iodef-pb-simple

Reported by: jul_bsd@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: mojca (Mojca Miklavec)
Port: p5-iodef-pb-simple

Description

Perl extension providing high level API access to Iodef::Pb. It takes simple key-pair hashes and maps them to the appropriate IODEF classes using a Module::Pluggable framework of plugins.

Attachments (5)

Portfile.2 (858 bytes) - added by jul_bsd@… 7 years ago.
log.p5.16 (20.3 KB) - added by jul_bsd@… 7 years ago.
log.p5.18 (20.6 KB) - added by jul_bsd@… 7 years ago.
Portfile.3 (1.0 KB) - added by mojca (Mojca Miklavec) 7 years ago.
slight modifications
Portfile (1.8 KB) - added by jul_bsd@… 7 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 7 years ago by jul_bsd@…

I move dependencies to perl5.branch -like (which would be nice if it was existing)

comment:2 Changed 7 years ago by mf2k (Frank Schima)

Some Notes:

  • Variants for perl versions make no sense for a perl module using the perl portgroup. The sub-ports are automatic.
  • The dependencies need to be fixed for all sub-ports.
  • Use modern checksums

comment:3 Changed 7 years ago by jul_bsd@…

I join a file which revert to p5- dependencies and updated checksums.

  • I think I did that because dependencies where not resolving correctly without. I replace dependencies with p5- something but that doesn't seem correct to me. I joined a port destroot log for 5.16 and 5.18 and p5.12 ports are appearing and corresponding deps are not installed. or the problem is with p5-json-xs ? doesn't seem so.
  • what do you mean? there is no subport here or do you mean other ports depending on this one? the problem was more when other port ask for this one, the dependencies list generated mixed multiple versions of perl
  • see #43238

Changed 7 years ago by jul_bsd@…

Attachment: Portfile.2 added

Changed 7 years ago by jul_bsd@…

Attachment: log.p5.16 added

Changed 7 years ago by jul_bsd@…

Attachment: log.p5.18 added

comment:4 Changed 7 years ago by mf2k (Frank Schima)

What I mean is that it is not correct to depend on the stub ports p5-*. Instead you must use the following construct which appears in many p5-* ports. The stub port itself does not actually do or install anything and does not have any dependencies.

if {${perl5.major} != ""} {
    depends_lib-append  port:p${perl5.major}-foo1 \
                        port:p${perl5.major}-foo2 \
                        ...
}

comment:5 Changed 7 years ago by mf2k (Frank Schima)

To clarify, notice the difference between the stub port and an actual sub-port:

$ port deps p5-wx
Full Name: p5-wx @0.992.300_0
Library Dependencies: p5.16-wx

$ port deps p5.16-wx
Full Name: p5.16-wx @0.992.300_0
Build Dependencies:   p5.16-extutils-xspp
Library Dependencies: perl5.16, p5.16-alien-wxwidgets, wxWidgets-3.0

comment:6 Changed 7 years ago by jul_bsd@…

yeah, just saw that while reviewing other port

comment:7 Changed 7 years ago by mojca (Mojca Miklavec)

Cc: mojca@… added

Cc Me!

comment:8 Changed 7 years ago by mojca (Mojca Miklavec)

Clicking dependencies on http://search.cpan.org/dist/Iodef-Pb-Simple/ shows a lot other dependencies. I didn't check which of these are really needed, but many of them are missing in your port.

Changed 7 years ago by mojca (Mojca Miklavec)

Attachment: Portfile.3 added

slight modifications

comment:9 Changed 7 years ago by mojca (Mojca Miklavec)

I think you should also attempt to make the description shorter. Put the full description into long_description and try to shorten the main one.

Changed 7 years ago by jul_bsd@…

Attachment: Portfile added
Note: See TracTickets for help on using tickets.