Opened 10 years ago

Closed 7 years ago

#43240 closed update (fixed)

py-m2crypto: update

Reported by: jul_bsd@… Owned by: aque (Allan Que)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: petrrr
Port: py-m2crypto

Description

recommended from grr port #42692 fix some leak, probably better to include as it seems project m2crypto is inactive for now, maybe need to review some of the github pull request too

Attachments (2)

m2crypto-fixes.diff (50.4 KB) - added by jul_bsd@… 10 years ago.
patch-py-m2crypto-Portfile.diff (1.7 KB) - added by jul_bsd@… 10 years ago.

Download all attachments as: .zip

Change History (14)

Changed 10 years ago by jul_bsd@…

Attachment: m2crypto-fixes.diff added

comment:1 Changed 10 years ago by mf2k (Frank Schima)

Cc: ram@… removed
Owner: changed from macports-tickets@… to ram@…

comment:2 Changed 10 years ago by skymoo (Adam Mercer)

Is this needed on 0.22.3? It also seems like a new maintainer is in the process of taking over...

comment:3 Changed 10 years ago by jul_bsd@…

I was said so by grr team (#42692), patch applies normally. I saw there was a new maintainer but there are still issues in treatment and no visibility on release, so prefer to have a fix before.

comment:4 Changed 10 years ago by jul_bsd@…

  • update to 0.22.3
  • change homepage with timeout now
  • add a subport -devel with latest git commit, only for py27 as it seems macports doesnot handle python branch for subport
  • comment the patch and put an entry in osafoundation bugzilla to ask an update and a pull request in the new repository

comment:5 Changed 10 years ago by skymoo (Adam Mercer)

Applied the update to 0.22.3 in r120180, haven't added the following hunks:

+## fix some leaks: https://code.google.com/p/grr/wiki/M2CryptoFromSource
+## maybe review more: https://github.com/martinpaljak/M2Crypto/pulls
+## 	https://bugzilla.osafoundation.org/show_bug.cgi?id=13005
+##	need to remove _lib.h part if > 0.21.1
+#patchfiles         patch-m2crypto-fixes.diff

as it's just a comment, also not sure on the addition of a devel variant:

+# FIXME! python subgroup doesn't seem to handle well subport or else
+#subport ${name}-devel {
+subport py27-m2crypto-devel {
+    python.versions    27
+    fetch.type git
+    git.url    https://github.com/martinpaljak/M2Crypto.git
+    git.branch 9abed178ed257d1bd2efbb16f7512e964f85d006
+
+    conflicts  ${name}
+}

As it has the same version as the standard port, if it has the same version then surely there's no need for a devel version. If it's different it should use a different version number.

comment:6 Changed 10 years ago by jul_bsd@…

Thanks ram@

I resubmit the patch with a version for devel (basically 0.22.3-<date> as it's just current head of devel. The port has a history of slow updates, so I think it's better to leave user the possibilty to choose for non-releases but could evolved with new maintainer.

it also seems there a was a new/cleaner github repository, so I put them in comments as for now, it doesn't seem synchronized

Changed 10 years ago by jul_bsd@…

comment:7 Changed 10 years ago by skymoo (Adam Mercer)

Owner: changed from ram@… to macports-tickets@…

dropped maintainership

comment:8 Changed 9 years ago by petrrr

Cc: petr@… added

Cc Me!

comment:9 Changed 9 years ago by petrrr

Summary: [update] m2crypto patchpy-m2crypto: update

comment:10 Changed 9 years ago by mf2k (Frank Schima)

Keywords: haspatch removed

This patch has a typo and would break the port.

comment:11 Changed 7 years ago by mf2k (Frank Schima)

Owner: changed from macports-tickets@… to aque
Status: newassigned

comment:12 Changed 7 years ago by aque (Allan Que)

Resolution: fixed
Status: assignedclosed

In 35451ac573707202488e137146d605005162722a/macports-ports:

py-m2crypto: update to 0.26.0

closes: #43240

Note: See TracTickets for help on using tickets.