Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#43253 closed defect (fixed)

nettle: universal build assumes Intel build platform

Reported by: t.tensi@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: Cc: exodusd@…, nicke@…, cooljeanius (Eric Gallager), jeremyhu (Jeremy Huddleston Sequoia), ryandesign (Ryan Schmidt)
Port: nettle

Description

Dear all,

there is a problem with the current nettle portfile 2.7.1: when building universal it blindly assumes an Intel machine as the host. I have run it on a PowerPC Mac and here the line

    set merger_configure_args(i386) --build=i686-apple-${os.platform}${os.major}

does of course pose problems (I have attached a portfile that does a case distinction).

I would also recommend to introduce a temporary variable like

set suffix apple-${os.platform}${os.major}

that may be used to simplify the file significantly.

I am not sure whether all the build and host settings in the portfile are already covered by the muniversal group in the header and the general mechanisms of MacPorts. So maybe those lines are completely obsolete.

Best regards,

Thomas

Attachments (1)

Portfile.diff (1.7 KB) - added by t.tensi@… 6 years ago.
diff for nettle portfile to include PPC build

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by t.tensi@…

Attachment: Portfile.diff added

diff for nettle portfile to include PPC build

comment:1 Changed 6 years ago by cooljeanius (Eric Gallager)

the variable that is being set is just for the i386 build though... afaik, the flags for building under ppc would use the merger_configure_args(ppc) variable instead, I think...

comment:2 Changed 6 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:3 Changed 6 years ago by ryandesign (Ryan Schmidt)

Cc: jeremyhu@… added
Summary: universal build in nettle assumes Intel build platformnettle: universal build assumes Intel build platform

The code in question was added to the portfile in r111066. I don't quite understand why any of it was necessary...

comment:4 Changed 6 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added

Cc Me!

comment:5 Changed 6 years ago by jeremyhu (Jeremy Huddleston Sequoia)

That was added because the port failed at cross compilation.

comment:6 Changed 6 years ago by jeremyhu (Jeremy Huddleston Sequoia)

If upstream fixed it in a newer build, try just removing that goop and see if it now works. Their build system only worked right if host == build.

comment:7 Changed 5 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: newclosed

Goop removed in r136968. Verified this fixed building universal on a Power Mac running 10.5 and on a 32-bit Intel iMac running 10.6.

comment:8 in reply to:  7 Changed 5 years ago by t.tensi@…

Hello Ryan,

thanks for your effort! I will check this on 10.4 as soon as possible and give feedback when anything goes wrong.

Best regards, Thomas

Note: See TracTickets for help on using tickets.