tftp-hpa 0.48: update to 5.2

[jul_bsd@…]

• bump to 5.2
• use notes instead of ui_msg (#31740)
• compile fails on

:info:build /usr/bin/clang -pipe -Os -arch x86_64 -W -Wall -Wpointer-arith -Wbad-function-cast -Wcast-equal -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -Winline -Wwrite-strings -Wundef -Wshadow -Wsign-compare -pipe -fno-strict-aliasing -I/Volumes/Data/opt/local/var/macports/build/_Volumes_Data_myports_net_tftp-hpa/tftp-hpa/work/tftp-hpa-5.2 -c recvfrom.c
:info:build sed -e 's/@@VERSION@@/5.2/g' < tftp.1.in > tftp.1
:info:build /usr/bin/clang -L/opt/local/lib -Wl,-headerpad_max_install_names -arch x86_64 tftp.o main.o ../common/libcommon.a -lreadline -ltermcap  /Volumes/Data/opt/local/var/macports/build/_Volumes_Data_myports_net_tftp-hpa/tftp-hpa/work/tftp-hpa-5.2/lib/libxtra.a  -o tftp 
:info:build warning: unknown warning option '-Wcast-equal'; did you mean '-Wfloat-equal'? [-Wunknown-warning-option]
:info:build recvfrom.c:225:42: error: use of undeclared identifier 'IPV6_RECVPKTINFO'
:info:build                     (cmptr->cmsg_type == IPV6_RECVPKTINFO ||
:info:build                                          ^
:info:build recvfrom.c:226:42: error: use of undeclared identifier 'IPV6_PKTINFO'
:info:build                      cmptr->cmsg_type == IPV6_PKTINFO)) {
:info:build                                          ^
:info:build 1 warning and 2 errors generated.            
:info:build make[1]: *** [recvfrom.o] Error 1

adjust w ​https://supportforums.cisco.com/discussion/10631451/solaris-tftp-server-tftpd-handle-32mb-files
similar problem seen on
​http://sourceforge.net/p/openvpn/mailman/openvpn-devel/thread/4F4B5535.40709@topphemmelig.net/
#31614

• add missing depends_lib
• livecheck working without any declarations

[cooljeanius (Eric Gallager)]

Cc Me!

[jul_bsd@…]

• port lint --nitpick
• livecheck
• /tab/spacex4/

[neverpanic (Clemens Lang)]

Maintainer timeout, committed in r119200.

[neverpanic (Clemens Lang)]

The build failed on the Snow Leopard buildbot: ​https://build.macports.org/builders/buildports-snowleopard-x86_64/builds/25894. The error is

In file included from main.c:44:
/opt/local/include/readline/readline.h:385: warning: function declaration isn’t a prototype
tftp.c:48:1: warning: "PKTSIZE" redefined
In file included from /opt/local/var/macports/build/_opt_mports_dports_net_tftp-hpa/tftp-hpa/work/tftp-hpa-5.2/config.h:282,
                 from /opt/local/var/macports/build/_opt_mports_dports_net_tftp-hpa/tftp-hpa/work/tftp-hpa-5.2/common/tftpsubs.h:41,
                 from tftp.c:34:
/usr/include/arpa/tftp.h:43:1: warning: this is the location of the previous definition
recvfrom.c: In function ‘myrecvfrom’:
recvfrom.c:231: error: ‘IPV6_RECVPKTINFO’ undeclared (first use in this function)
recvfrom.c:231: error: (Each undeclared identifier is reported only once
recvfrom.c:231: error: for each function it appears in.)
make[1]: *** [recvfrom.o] Error 1
make[1]: *** Waiting for unfinished jobs....

Looks a lot like the problem you tried to fix using the patch, right?

[jul_bsd@…]

the openvpn link mentionned the above error for snow leopard too but with the patch, it shouldn't happen unless HAVE_STRUCT_IN6_PKTINFO is not rightly set. I add an extra ifdef layer following openvpn example testing directly IPV6_RECVPKTINFO. Hope it will be enough The RFC3542 mentionned in #31614 is not enough

Could you give a try with the new patch?

[neverpanic (Clemens Lang)]

Patch committed in r119209, let's see what the buildbot says… success: ​https://build.macports.org/builders/buildports-snowleopard-x86_64/builds/25900/steps/compile/logs/progress.

[jul_bsd@…]

sorry. incorrect tab. please delete last diff.

Good work for commit. Thanks!