Opened 10 years ago

Closed 10 years ago

#43283 closed defect (fixed)

gtk3 @3.12.0 +quartz build fails on OS X 10.6.8

Reported by: mopihopi Owned by: neverpanic (Clemens Lang)
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: haspatch Cc: bitpup, cooljeanius (Eric Gallager), khepler, zzanderr
Port: gtk3

Description

--->  Building gtk3
Error: org.macports.build for port gtk3 returned: command execution failed
Please see the log file for port gtk3 for details:
    /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_ports_gnome_gtk3/gtk3/main.log
Error: Unable to upgrade port: 1
To report a bug, follow the instructions in the guide:
    http://guide.macports.org/#project.tickets

The previously available version (gtk3 @3.10.7_0+quartz) builds successfully.

The build error is:

      scale = roundf ([[NSScreen mainScreen] backingScaleFactor]);
:info:build gtkapplication-quartz-menu.c: In function '-[GNSMenuItem didChangeIcon]':
:info:build gtkapplication-quartz-menu.c:265: warning: 'NSScreen' may not respond to '-backingScaleFactor'
:info:build gtkapplication-quartz-menu.c:265: warning: (Messages without a matching method signature
:info:build gtkapplication-quartz-menu.c:265: warning: will be assumed to return 'id' and accept
:info:build gtkapplication-quartz-menu.c:265: warning: '...' as arguments.)
:info:build gtkapplication-quartz-menu.c:265: error: incompatible type for argument 1 of 'roundf'
:info:build make[4]: *** [libgtk_3_la-gtkapplication-quartz-menu.lo] Error 1

The backingScaleFactor method was added to NSScreen in OS X 10.7.

Attachments (2)

main.log (2.0 MB) - added by mopihopi 10 years ago.
patch-backingScaleFactor.diff (935 bytes) - added by devernay (Frédéric Devernay) 10 years ago.
patchfile

Change History (10)

Changed 10 years ago by mopihopi

Attachment: main.log added

comment:1 Changed 10 years ago by bitpup

Cc: wheeltong@… added

Cc Me!

comment:2 Changed 10 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:3 Changed 10 years ago by neverpanic (Clemens Lang)

Cc: cal@… removed
Owner: changed from macports-tickets@… to cal@…
Status: newassigned

comment:4 Changed 10 years ago by khepler

Cc: khepler@… added

Cc Me!

comment:5 Changed 10 years ago by zzanderr

Cc: zanderpower@… added

Cc Me!

Changed 10 years ago by devernay (Frédéric Devernay)

patchfile

comment:6 Changed 10 years ago by devernay (Frédéric Devernay)

This patch enables compilation with the 10.6 SDK, and if running on 10.7 it properly gets the backingScaleFactor property. If running on 10.6 or below, scale is set to 1.

comment:7 Changed 10 years ago by dbevans (David B. Evans)

Keywords: haspatch added

comment:8 Changed 10 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: assignedclosed

Committed in r120176.

Note: See TracTickets for help on using tickets.